You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/03/12 09:56:48 UTC
[GitHub] [incubator-iotdb] JulianFeinauer commented on a change in pull
request #93: [IOTDB-39]add autoRepair option for NativeRestorableIOWriter
JulianFeinauer commented on a change in pull request #93: [IOTDB-39]add autoRepair option for NativeRestorableIOWriter
URL: https://github.com/apache/incubator-iotdb/pull/93#discussion_r264596089
##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/NativeRestorableIOWriter.java
##########
@@ -53,6 +53,15 @@ long getTruncatedPosition() {
}
public NativeRestorableIOWriter(File file) throws IOException {
+ this(file, true);
Review comment:
Perhaps we should set the default to false to keep the behavior "as is".
But otherwise "true" is more comfortable for the user.
I agree with both, just wanted to bring this point up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services