[GitHub] [airflow] potiuk commented on pull request #18652: Add banner indicating environment type

[GitBox <gi...@apache.org>]

potiuk commented on pull request #18652:
URL: https://github.com/apache/airflow/pull/18652#issuecomment-932974022


   I agree with @turbaszek  that it is a good idea. Actually the fact that you need to explain to the users something with "Did you actually know that you can do this and this to achieve that"? means that there is something wrong with the feature - it's either not obvious, not discoverable, or maybe it has many overlapping uses, which make it difficult to understand and even realise that you can already do something (albeit in a convoluted way).
   
   There are various reasons why you would like to change instance name, or change navbar colour - for example due to matching your colors with the company "color theme" or naming your instances via department. However explicitly naming the option "as environment"  which would be "orthognal" to that and much more visible is a good idea:
   
   * it serves the explicit use case and only that one (without blocking the other use cases i mentioned above).
   
   * I think this use case is rather popular and very much "technical" one - in terms that it is good to have something "extra" shown in "dev/staging" environments, to clearly distinguish them and let the user know that this environment is not the one which is "production". Using other elements (already existing ones but modifying them) is not as "visually distinctive".
   
   * the use case is often  requesteded and popular and we have a chance the user to find answer on "how I should configure staging environment" in the docs and configuration of Airflow rather than in Stack Overflow / LinkedIn posts. 
   
   
   I would be very much for explicit "environment" flag like @turbaszek is proposing.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org