You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/01/20 20:56:19 UTC

Review Request 55784: Log Search should handle new services

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55784/
-----------------------------------------------------------

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-19659
    https://issues.apache.org/jira/browse/AMBARI-19659


Repository: ambari


Description
-------

Log Search should be restarted if the logfeeder configuration changes in order to refresh HadoopServiceConfig.json to show the new services on the Troubleshooting page. Also it should add the default filters for the new logs.


Diffs
-----

  ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 13d7e03 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 432bd58 

Diff: https://reviews.apache.org/r/55784/diff/


Testing
-------

Tested on local cluster


Thanks,

Miklos Gergely


Re: Review Request 55784: Log Search should handle new services

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55784/#review162501
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On Jan. 20, 2017, 8:56 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55784/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 8:56 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19659
>     https://issues.apache.org/jira/browse/AMBARI-19659
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Log Search should be restarted if the logfeeder configuration changes in order to refresh HadoopServiceConfig.json to show the new services on the Troubleshooting page. Also it should add the default filters for the new logs.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 13d7e03 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 432bd58 
> 
> Diff: https://reviews.apache.org/r/55784/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 55784: Log Search should handle new services

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55784/#review162502
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On Jan. 20, 2017, 8:56 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55784/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 8:56 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19659
>     https://issues.apache.org/jira/browse/AMBARI-19659
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Log Search should be restarted if the logfeeder configuration changes in order to refresh HadoopServiceConfig.json to show the new services on the Troubleshooting page. Also it should add the default filters for the new logs.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 13d7e03 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 432bd58 
> 
> Diff: https://reviews.apache.org/r/55784/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 55784: Log Search should handle new services

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55784/
-----------------------------------------------------------

(Updated Jan. 20, 2017, 10:05 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
-------

Use service level dependencies


Bugs: AMBARI-19659
    https://issues.apache.org/jira/browse/AMBARI-19659


Repository: ambari


Description
-------

Log Search should be restarted if the logfeeder configuration changes in order to refresh HadoopServiceConfig.json to show the new services on the Troubleshooting page. Also it should add the default filters for the new logs.


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 13d7e03 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 432bd58 

Diff: https://reviews.apache.org/r/55784/diff/


Testing
-------

Tested on local cluster


Thanks,

Miklos Gergely