You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/04/20 12:40:27 UTC

[GitHub] [couchdb] rnewson commented on pull request #4000: Ensure Object.prototype.toSource is always available

rnewson commented on PR #4000:
URL: https://github.com/apache/couchdb/pull/4000#issuecomment-1103885590

   I've revised the intent here since I started after learning (more than I really wanted to!) about couchjs and spidermonkey. Object.prototype.toSource() is available in all versions of spidermonkey that we support but, in later versions, must be explicitly enabled. The value of the result of toSource() is significant and we'd like to keep it.
   
   We missed a spot when enabling the flag, which this PR corrects.
   
   Since toSource() will always work, I have removed all the guarding that would call toString() (with its unhelpful output) as a fallback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org