You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/27 17:53:10 UTC
[GitHub] [incubator-seatunnel] HeZean opened a new pull request, #2280: [CI][doc] Add build CI for document changes
HeZean opened a new pull request, #2280:
URL: https://github.com/apache/incubator-seatunnel/pull/2280
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Closes #1716
When a PR changes the docs, this workflow will try build the website based on the changes, note that this won't affect the existing website repo.
Acknowledgement: `sync.sh` uses several util functions in [incubator-seatunnel-website/tools/build-docs.sh](https://github.com/apache/incubator-seatunnel-website/blob/main/tools/build-docs.sh)
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason: *manually tested*
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #2280: [CI][doc] Add build CI for document changes
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #2280:
URL: https://github.com/apache/incubator-seatunnel/pull/2280#issuecomment-1197598611
@HeZean can you add some random changes in the `docs/**` and see how the workflow works? After that we can revert the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2280: [CI][doc] Add build CI for document changes
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2280:
URL: https://github.com/apache/incubator-seatunnel/pull/2280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2280: [CI][doc] Add build CI for document changes
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2280:
URL: https://github.com/apache/incubator-seatunnel/pull/2280#discussion_r931717578
##########
tools/documents/sync.sh:
##########
@@ -0,0 +1,112 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
Review Comment:
Hi you should add the license header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HeZean commented on a diff in pull request #2280: [CI][doc] Add build CI for document changes
Posted by GitBox <gi...@apache.org>.
HeZean commented on code in PR #2280:
URL: https://github.com/apache/incubator-seatunnel/pull/2280#discussion_r931725402
##########
tools/documents/sync.sh:
##########
@@ -0,0 +1,112 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
Review Comment:
Thanks for reminding, my oversight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HeZean commented on pull request #2280: [CI][doc] Add build CI for document changes
Posted by GitBox <gi...@apache.org>.
HeZean commented on PR #2280:
URL: https://github.com/apache/incubator-seatunnel/pull/2280#issuecomment-1197605867
@kezhenxu94 please check https://github.com/HeZean/incubator-seatunnel/pull/2, you can find the log [here](https://github.com/HeZean/incubator-seatunnel/runs/7552651707?check_suite_focus=true)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org