[GitHub] [iceberg] rdblue commented on a change in pull request #2034: AWS: add DynamoDB implementation of Glue lock manager

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2034:
URL: https://github.com/apache/iceberg/pull/2034#discussion_r552296863



##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/LockManager.java
##########
@@ -36,9 +36,12 @@
 
   /**
    * Release a lock
+   *
+   * @apiNote exception must not be thrown for this method.
+   *
    * @param entityId ID of the entity to lock
    * @param ownerId ID of the owner if the lock
-   * @return if the lock for the entity of the owner is released
+   * @return if the owner held the key and successfully released it.

Review comment:
       Key? I think you might still mean "lock"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org