You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2018/05/03 19:33:00 UTC

[jira] [Resolved] (HBASE-20507) Do not need to call recoverLease on the broken file when we fail to create a wal writer

     [ https://issues.apache.org/jira/browse/HBASE-20507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-20507.
---------------------------
       Resolution: Fixed
    Fix Version/s: 3.0.0

Re-resolving.

> Do not need to call recoverLease on the broken file when we fail to create a wal writer
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-20507
>                 URL: https://issues.apache.org/jira/browse/HBASE-20507
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0, 2.0.1
>
>         Attachments: 20507.addendum.patch, HBASE-20507.patch
>
>
> I tried locally with a UT, if we overwrite a file which is currently being written, the old file will be completed and then deleted. If you call close on the previous file, a no lease exception will be thrown which means that the file has already been completed.
> So we do not need to close a file if it will be overwritten immediately, since recoverLease may take a very long time...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)