You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/18 11:11:18 UTC

[GitHub] [arrow] alamb commented on a change in pull request #9214: ARROW-11268: [Rust][DataFusion] MemTable::load output partition support

alamb commented on a change in pull request #9214:
URL: https://github.com/apache/arrow/pull/9214#discussion_r559487823



##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -66,6 +66,10 @@ struct BenchmarkOpt {
     /// Load the data into a MemTable before executing the query
     #[structopt(short = "m", long = "mem-table")]
     mem_table: bool,
+
+    /// Number of partitions to use when using MemTable

Review comment:
       ```suggestion
       /// Number of partitions to create when using MemTable as input
   ```

##########
File path: rust/datafusion/src/datasource/memory.rs
##########
@@ -126,6 +134,28 @@ impl MemTable {
             data.push(result);
         }
 
+        let exec = MemoryExec::try_new(&data, schema.clone(), None)?;
+
+        if let Some(num_partitions) = output_partitions {

Review comment:
       👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org