[jira] Commented: (HARMONY-4000) [drlvm][em] DRLEM profile collectors code to access method profiles is not thread safe

["Alexey Varlamov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500353 ] 

Alexey Varlamov commented on HARMONY-4000:
------------------------------------------

Fix looks correct. I'd also suggest to define lock/unlock routines in the base class ProfileCollector instead of adding mutex to each subclass. BTW, those get/create methods probably should be declared in the base class also.

    virtual MethodProfile* getMethodProfile(Method_Handle mh) const ;
    vritual MethodProfile* createProfile(Method_Handle mh);


> [drlvm][em] DRLEM profile collectors code to access method profiles is not thread safe
> --------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4000
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4000
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>            Assignee: Alexey Varlamov
>         Attachments: em.diff
>
>
> DRLEM profile collectors code to access method profiles is not thread safe.
> All 3 profile collectors: entry-backedge, edge and value profilers, do not use locks in getMethodProfile routine.
> However the map that is used to keep method<->profile mapping can be modified from a separate thread when new profile is created.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.