You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/01/22 06:13:12 UTC

[Impala-ASF-CR] IMPALA-9312: Better error handling for run clang tidy.sh 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15090


Change subject: IMPALA-9312: Better error handling for run_clang_tidy.sh
......................................................................

IMPALA-9312: Better error handling for run_clang_tidy.sh

This turns a buildall.sh failure into a job failure and
dumps full output of the script.

Change-Id: I4a90e5b48f0d75b0a1c52cfe629c22bd37c70b26
---
M bin/run_clang_tidy.sh
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/15090/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a90e5b48f0d75b0a1c52cfe629c22bd37c70b26
Gerrit-Change-Number: 15090
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9312: Better error handling for run clang tidy.sh

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15090 )

Change subject: IMPALA-9312: Better error handling for run_clang_tidy.sh
......................................................................

IMPALA-9312: Better error handling for run_clang_tidy.sh

This turns a buildall.sh failure into a job failure and
dumps full output of the script.

Change-Id: I4a90e5b48f0d75b0a1c52cfe629c22bd37c70b26
Reviewed-on: http://gerrit.cloudera.org:8080/15090
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M bin/run_clang_tidy.sh
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Quanlong Huang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a90e5b48f0d75b0a1c52cfe629c22bd37c70b26
Gerrit-Change-Number: 15090
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9312: Better error handling for run clang tidy.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15090 )

Change subject: IMPALA-9312: Better error handling for run_clang_tidy.sh
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5492/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a90e5b48f0d75b0a1c52cfe629c22bd37c70b26
Gerrit-Change-Number: 15090
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 06:58:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9312: Better error handling for run clang tidy.sh

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15090 )

Change subject: IMPALA-9312: Better error handling for run_clang_tidy.sh
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a90e5b48f0d75b0a1c52cfe629c22bd37c70b26
Gerrit-Change-Number: 15090
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 07:32:52 +0000
Gerrit-HasComments: No