You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Chris Custine (JIRA)" <ji...@apache.org> on 2009/05/01 09:23:38 UTC
[jira] Created: (SMXCOMP-531) Improve test coverage - ServiceMix ::
EIP
Improve test coverage - ServiceMix :: EIP
-----------------------------------------
Key: SMXCOMP-531
URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
Project: ServiceMix Components
Issue Type: Test
Components: servicemix-eip
Affects Versions: servicemix-eip-2009.01
Reporter: Chris Custine
http://nemo.sonar.codehaus.org/project/index/94778
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SMXCOMP-531) Improve test coverage - ServiceMix ::
EIP
Posted by "Jean Jacobs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean Jacobs updated SMXCOMP-531:
--------------------------------
Attachment: eipUnitTests32.patch
Attached is a patch for the backport of the tests to servicemix-3.2.
> Improve test coverage - ServiceMix :: EIP
> -----------------------------------------
>
> Key: SMXCOMP-531
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-eip
> Affects Versions: servicemix-eip-2009.01
> Reporter: Chris Custine
> Assignee: Freeman Fang
> Attachments: eipTestProperties.patch, eipUnitTests.patch, eipUnitTests32.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/94778
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMXCOMP-531) Improve test coverage - ServiceMix
:: EIP
Posted by "Jean Jacobs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51840#action_51840 ]
Jean Jacobs commented on SMXCOMP-531:
-------------------------------------
I would like to contribute tests for this component.
> Improve test coverage - ServiceMix :: EIP
> -----------------------------------------
>
> Key: SMXCOMP-531
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-eip
> Affects Versions: servicemix-eip-2009.01
> Reporter: Chris Custine
>
> http://nemo.sonar.codehaus.org/project/index/94778
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SMXCOMP-531) Improve test coverage - ServiceMix ::
EIP
Posted by "Jean Jacobs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean Jacobs updated SMXCOMP-531:
--------------------------------
Attachment: eipUnitTests.patch
Attached is a patch containing unit tests that increase the Unit Test coverage for the servicemix-eip component from 65% to 71%.
> Improve test coverage - ServiceMix :: EIP
> -----------------------------------------
>
> Key: SMXCOMP-531
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-eip
> Affects Versions: servicemix-eip-2009.01
> Reporter: Chris Custine
> Attachments: eipUnitTests.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/94778
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SMXCOMP-531) Improve test coverage - ServiceMix
:: EIP
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang reassigned SMXCOMP-531:
------------------------------------
Assignee: Freeman Fang
> Improve test coverage - ServiceMix :: EIP
> -----------------------------------------
>
> Key: SMXCOMP-531
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-eip
> Affects Versions: servicemix-eip-2009.01
> Reporter: Chris Custine
> Assignee: Freeman Fang
> Attachments: eipUnitTests.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/94778
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SMXCOMP-531) Improve test coverage - ServiceMix ::
EIP
Posted by "Jean Jacobs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean Jacobs updated SMXCOMP-531:
--------------------------------
Attachment: eipTestProperties.patch
Attached is a patch that contains the properties files that I forgot.
I will work on the patch for servicmix 3.2 branch now.
> Improve test coverage - ServiceMix :: EIP
> -----------------------------------------
>
> Key: SMXCOMP-531
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-eip
> Affects Versions: servicemix-eip-2009.01
> Reporter: Chris Custine
> Assignee: Freeman Fang
> Attachments: eipTestProperties.patch, eipUnitTests.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/94778
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMXCOMP-531) Improve test coverage - ServiceMix
:: EIP
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52138#action_52138 ]
Freeman Fang commented on SMXCOMP-531:
--------------------------------------
Hi Jean,
You patch cause a test failure at
Test set: org.apache.servicemix.eip.MessageFilterSwitchPredicateTest
-------------------------------------------------------------------------------
Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.753 sec <<< FAILURE!
testPropertyFromFile(org.apache.servicemix.eip.MessageFilterSwitchPredicateTest) Time elapsed: 0.012 sec <<< ERROR!
java.lang.NullPointerException
at org.apache.servicemix.eip.MessageFilterSwitchPredicateTest.testPropertyFromFile(MessageFilterSwitchPredicateTest.java:91)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
I investigate it a little bit, seems your patch miss a file switch-off.properties (also switch.properties) which cause the NPE
URL fileUrl = getClass().getResource("switch-off.properties");//so the fileUrl is NULL here.
Could you append the missing properties ? And would you please create patch against 3.2 branch also?
Thanks
Freeman
> Improve test coverage - ServiceMix :: EIP
> -----------------------------------------
>
> Key: SMXCOMP-531
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-eip
> Affects Versions: servicemix-eip-2009.01
> Reporter: Chris Custine
> Assignee: Freeman Fang
> Attachments: eipUnitTests.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/94778
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SMXCOMP-531) Improve test coverage - ServiceMix
:: EIP
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved SMXCOMP-531.
----------------------------------
Resolution: Fixed
Fix Version/s: servicemix-eip-2009.02
3.2.4
apply patch on behalf of Jean Jacobs with thanks
http://svn.apache.org/viewvc?rev=783597&view=rev for 3.2 branch
http://svn.apache.org/viewvc?rev=782998&view=rev for servicemix-eip component project
> Improve test coverage - ServiceMix :: EIP
> -----------------------------------------
>
> Key: SMXCOMP-531
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-eip
> Affects Versions: servicemix-eip-2009.01
> Reporter: Chris Custine
> Assignee: Freeman Fang
> Fix For: 3.2.4, servicemix-eip-2009.02
>
> Attachments: eipTestProperties.patch, eipUnitTests.patch, eipUnitTests32.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/94778
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.