You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "paulirwin (via GitHub)" <gi...@apache.org> on 2026/09/04 13:30:46 UTC
[PR] Fix editorconfig-checker url and pin to 4.0.1 [lucenenet]
paulirwin opened a new pull request, #1448:
URL: https://github.com/apache/lucenenet/pull/1448
- [X] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/master/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
- [ ] You've included unit or integration tests for your change, where applicable.
- [ ] You've included inline docs for your change, where applicable.
- [ ] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue.
Fix editorconfig-checker url and pin to 4.0.1
## Description
The download URL for the "latest" release of editorconfig-checker moved. This fixes the download URL and also pins to 4.0.1 so this isn't a moving target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix editorconfig-checker url and pin to 4.0.1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on PR #1448:
URL: https://github.com/apache/lucenenet/pull/1448#issuecomment-5602703186
> > We should run the editorconfig checker with prek. Some of the other ASF projects already do this and having the editorconfig checks/tests run on your local machine is faster and saves CI time. You get immediate feedback.
> > Seems to be more effective in finding formatting and linting errors as well
> > https://github.com/apache/shiro/blob/ca444c3332b5996a1c7c75eed610a9598c0ca5a9/.pre-commit-config.yaml#L231
> > https://github.com/editorconfig-checker/editorconfig-checker.python
>
> @jbampton - I don't have any objections to doing this. In fact, it will reduce the number of agents we use by 1 if we add it to the combined script. Having it run locally would be great, also, although it may be most helpful if it is added either as some sort of IDE extension or possibly a build target so it isn't an extra manual step.
>
> That said, I think that should be a new issue since we should merge this ASAP to stop the build from failing.
Agreed on it being a new issue.
However, pre-commit hooks are better than an IDE extension. You install them once in your repo, and they run every commit, no matter how you write code (IDE, vim/notepad, or AI agent). The text output is also very AI agent friendly to fix issues. You don't have a "manual step" each commit; it runs automatically. IDE support is nice but is limited to those users using an IDE. I agree that we should pursue this in a separate issue/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix editorconfig-checker url and pin to 4.0.1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1448:
URL: https://github.com/apache/lucenenet/pull/1448#discussion_r3968987646
##########
.github/workflows/EditorConfig-Rules-Check.yml:
##########
@@ -11,15 +11,15 @@ jobs:
- name: Install EditorConfig Checker
run: |
- curl -sSfL https://github.com/editorconfig-checker/editorconfig-checker/releases/latest/download/ec-linux-amd64.tar.gz -o ec.tar.gz
+ curl -sSfL https://github.com/editorconfig-checker/editorconfig-checker/releases/download/v4.0.1/editorconfig-checker-linux-amd64.tar.gz -o ec.tar.gz
Review Comment:
Yeah, we've been bitten by automatic upgrades without us testing it out first. It's quite annoying when they change the rules and then a new thing breaks. We should upgrade this periodically only after confirming that it doesn't break the build and we fix any new issues it finds. That's why I chose to pin it (case in point, what caused this PR in the first place).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix editorconfig-checker url and pin to 4.0.1 [lucenenet]
Posted by "NightOwl888 (via GitHub)" <gi...@apache.org>.
NightOwl888 commented on code in PR #1448:
URL: https://github.com/apache/lucenenet/pull/1448#discussion_r3968223364
##########
.github/workflows/EditorConfig-Rules-Check.yml:
##########
@@ -11,15 +11,15 @@ jobs:
- name: Install EditorConfig Checker
run: |
- curl -sSfL https://github.com/editorconfig-checker/editorconfig-checker/releases/latest/download/ec-linux-amd64.tar.gz -o ec.tar.gz
+ curl -sSfL https://github.com/editorconfig-checker/editorconfig-checker/releases/download/v4.0.1/editorconfig-checker-linux-amd64.tar.gz -o ec.tar.gz
Review Comment:
I noticed in #1455 that there still is a way to target the latest version, but at the risk that a future release will change the file naming format again. But at the same time, it is probably fine to pin it and deal with periodic upgrades manually. Although, maybe there is a Renovate/Dependabot way to get notified about new releases...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix editorconfig-checker url and pin to 4.0.1 [lucenenet]
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #1448:
URL: https://github.com/apache/lucenenet/pull/1448#issuecomment-5553418069
We should run the editorconfig checker with prek. Some of the other ASF projects already do this and having the editorconfig checks/tests run on your local machine is faster and saves CI time. You get immediate feedback.
Seems to be more effective in finding formatting and linting errors as well
https://github.com/apache/shiro/blob/ca444c3332b5996a1c7c75eed610a9598c0ca5a9/.pre-commit-config.yaml#L231
https://github.com/editorconfig-checker/editorconfig-checker.python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix editorconfig-checker url and pin to 4.0.1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on PR #1448:
URL: https://github.com/apache/lucenenet/pull/1448#issuecomment-5543344432
@NightOwl888 Requesting your review since you originally added this.
I had to make a few more changes to support EditorConfig Checker 4.0.1:
- It now is more strict about a non-ASCII character in one of the Lucene test files, so that is now excluded (rather than patching the file; to keep it byte-for-byte identical to the Lucene version)
- It now no longer outputs the file name by default when run in GitHub Actions, because it is intending to add those as annotations (kinda like how `dotnet build` does if there's a warning) so you can see it in the PR. That's great, but it's also helpful to see the files in question in the command-line output, especially if the file was not touched in the PR. So I now run it twice if it fails the first time. The first run adds the GH actions annotations, the second run with the argument to use default mode outputs the files that are affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix editorconfig-checker url and pin to 4.0.1 [lucenenet]
Posted by "NightOwl888 (via GitHub)" <gi...@apache.org>.
NightOwl888 commented on PR #1448:
URL: https://github.com/apache/lucenenet/pull/1448#issuecomment-5601769142
> We should run the editorconfig checker with prek. Some of the other ASF projects already do this and having the editorconfig checks/tests run on your local machine is faster and saves CI time. You get immediate feedback.
>
> Seems to be more effective in finding formatting and linting errors as well
>
> https://github.com/apache/shiro/blob/ca444c3332b5996a1c7c75eed610a9598c0ca5a9/.pre-commit-config.yaml#L231
>
> https://github.com/editorconfig-checker/editorconfig-checker.python
@jbampton - I don't have any objections to doing this. In fact, it will reduce the number of agents we use by 1 if we add it to the combined script. Having it run locally would be great, also, although it may be most helpful if it is added either as some sort of IDE extension or possibly a build target so it isn't an extra manual step.
That said, I think that should be a new issue since we should merge this ASAP to stop the build from failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix editorconfig-checker url and pin to 4.0.1 [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin merged PR #1448:
URL: https://github.com/apache/lucenenet/pull/1448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org