You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2005/08/19 21:43:55 UTC

Re: svn commit: r233509 - /perl/Apache-Test/trunk/lib/Apache/TestConfig.pm

jorton@apache.org wrote:
> Author: jorton
> Date: Fri Aug 19 09:32:18 2005
> New Revision: 233509
> 
> URL: http://svn.apache.org/viewcvs?rev=233509&view=rev
> Log:
> Define a "MOD_FOO_PORT" variable from any <VirtualHost mod_foo> definition,
> so the port can be referenced by other directives.

Joe, mind to add a note about this feature in the documentation (the pod 
at the end of the file). Otherwise nobody will ever know that that feature 
is available. Thanks!

> Modified: perl/Apache-Test/trunk/lib/Apache/TestConfig.pm
> URL: http://svn.apache.org/viewcvs/perl/Apache-Test/trunk/lib/Apache/TestConfig.pm?rev=233509&r1=233508&r2=233509&view=diff
> ==============================================================================
> --- perl/Apache-Test/trunk/lib/Apache/TestConfig.pm (original)
> +++ perl/Apache-Test/trunk/lib/Apache/TestConfig.pm Fri Aug 19 09:32:18 2005
> @@ -1197,6 +1197,8 @@
>          }
>      }
>  
> +    $self->{vars}->{$module . '_port'} = $port;
> +
>      #there are two ways of building a vhost
>      #first is when we parse test .pm and .c files
>      #second is when we scan *.conf.in
> 


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: svn commit: r233509 - /perl/Apache-Test/trunk/lib/Apache/TestConfig.pm

Posted by Stas Bekman <st...@stason.org>.
Joe Orton wrote:
> On Fri, Aug 19, 2005 at 12:43:55PM -0700, Stas Bekman wrote:
> 
>>jorton@apache.org wrote:
>>
>>>Author: jorton
>>>Date: Fri Aug 19 09:32:18 2005
>>>New Revision: 233509
>>>
>>>URL: http://svn.apache.org/viewcvs?rev=233509&view=rev
>>>Log:
>>>Define a "MOD_FOO_PORT" variable from any <VirtualHost mod_foo> definition,
>>>so the port can be referenced by other directives.
>>
>>Joe, mind to add a note about this feature in the documentation (the pod 
>>at the end of the file). Otherwise nobody will ever know that that feature 
>>is available. Thanks!
> 
> 
> Where is an appropriate place?  The only place I could find about how 
> even the simple VirtualHost magic mapping happens is in 
> http://perl.apache.org/docs/general/testing/testing.html#Auto_Configuration 
> (part of the mod_perl docs?)

That will work. I hope one day someone will work on completing the missing 
documentation for the current functionality. But we should at least make 
sure that whenever new things are added they are documented :)



-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: svn commit: r233509 - /perl/Apache-Test/trunk/lib/Apache/TestConfig.pm

Posted by Joe Orton <jo...@redhat.com>.
On Fri, Aug 19, 2005 at 12:43:55PM -0700, Stas Bekman wrote:
> jorton@apache.org wrote:
> >Author: jorton
> >Date: Fri Aug 19 09:32:18 2005
> >New Revision: 233509
> >
> >URL: http://svn.apache.org/viewcvs?rev=233509&view=rev
> >Log:
> >Define a "MOD_FOO_PORT" variable from any <VirtualHost mod_foo> definition,
> >so the port can be referenced by other directives.
> 
> Joe, mind to add a note about this feature in the documentation (the pod 
> at the end of the file). Otherwise nobody will ever know that that feature 
> is available. Thanks!

Where is an appropriate place?  The only place I could find about how 
even the simple VirtualHost magic mapping happens is in 
http://perl.apache.org/docs/general/testing/testing.html#Auto_Configuration 
(part of the mod_perl docs?)

joe