You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Quinn Stevenson <qu...@pronoia-solutions.com> on 2015/12/22 19:53:13 UTC
JUnit Rule for Embedded Brokers
All -
I wrote a simple JUnit Rule to simplify setting up embedded ActiveMQ brokers for testing. I’ve been using it for some time now, and I find it very helpful.
I would like to contribute the component to the ActiveMQ project and I’m planning on creating a pull request for it, but I need a little help with where a component like this belongs in the source tree. I was thinking of either adding it to the activemq-unit-tests module, or creating a module for it under activemq-tooling.
Do either of these locations make sense? Or would another location/module be more appropriate?
Quinn Stevenson
quinn@pronoia-solutions.com
Re: JUnit Rule for Embedded Brokers
Posted by Quinn Stevenson <qu...@pronoia-solutions.com>.
I created a JIRA AMQ-6106 - JUnit Rule for embedded ActiveMQ Broker and pull request https://github.com/apache/activemq/pull/163 <https://github.com/apache/activemq/pull/163> for this a few days ago, but I haven’t heard anything back on whether or not this JUnit rule is something of interest to the community.
How long should I wait before closing the PR?
Quinn Stevenson
quinn@pronoia-solutions.com
(801) 244-7758
> On Dec 22, 2015, at 1:47 PM, Clebert Suconic <cl...@gmail.com> wrote:
>
> If u want to bootstrap a tooling project Its fine with git access etc.
>
> But maybe it would be easier as a folder in one of the projects.
>
>
> Sent from my iPhone
>
>> On Dec 22, 2015, at 3:14 PM, Christopher Shannon <ch...@gmail.com> wrote:
>>
>> It may need to go into a new subproject (as you pointed out, maybe under
>> tooling). While it could also just go into the activemqunit-l
>> project, there are unit tests in almost every sub project and it would be
>> nice if the JUnit Rule could be used in any of these projects. So, we'd
>> probably need to put it into a new tooling sub project and create a test
>> dependency for it.
>>
>>
>>
>> On Tue, Dec 22, 2015 at 2:49 PM, Quinn Stevenson <
>> quinn@pronoia-solutions.com> wrote:
>>
>>> Thank You for the information. I found the subproject on the ActiveMQ
>>> site, and I will be sure to get familiar with this.
>>>
>>> Since my needs are around JMS, I’ll work on a JUnit Rule for the Artemis
>>> EmbeddedJMS.
>>>
>>> Any suggestions on where to put the JUnit Rule for ActiveMQ 5.x in the
>>> source tree?
>>>
>>>>> On Dec 22, 2015, at 12:40 PM, Clebert Suconic <cl...@gmail.com>
>>>> wrote:
>>>>
>>>> On Tue, Dec 22, 2015 at 2:25 PM, Quinn Stevenson
>>>> <qu...@pronoia-solutions.com> wrote:
>>>>> Please forgive my ignorance here - but is Artemis the next major
>>> version of ActiveMQ? Or is it something else?
>>>>
>>>> I would prefer to say It's a sub project of ActiveMQ. A different
>>>> broker. We have been doing quite a lot of new development there.
>>>> If you look at the history it was a donation of hornetq to apache as a
>>>> sub project of activemq.
>>>
>>>
Re: JUnit Rule for Embedded Brokers
Posted by Clebert Suconic <cl...@gmail.com>.
If u want to bootstrap a tooling project Its fine with git access etc.
But maybe it would be easier as a folder in one of the projects.
Sent from my iPhone
> On Dec 22, 2015, at 3:14 PM, Christopher Shannon <ch...@gmail.com> wrote:
>
> It may need to go into a new subproject (as you pointed out, maybe under
> tooling). While it could also just go into the activemqunit-l
> project, there are unit tests in almost every sub project and it would be
> nice if the JUnit Rule could be used in any of these projects. So, we'd
> probably need to put it into a new tooling sub project and create a test
> dependency for it.
>
>
>
> On Tue, Dec 22, 2015 at 2:49 PM, Quinn Stevenson <
> quinn@pronoia-solutions.com> wrote:
>
>> Thank You for the information. I found the subproject on the ActiveMQ
>> site, and I will be sure to get familiar with this.
>>
>> Since my needs are around JMS, I’ll work on a JUnit Rule for the Artemis
>> EmbeddedJMS.
>>
>> Any suggestions on where to put the JUnit Rule for ActiveMQ 5.x in the
>> source tree?
>>
>>>> On Dec 22, 2015, at 12:40 PM, Clebert Suconic <cl...@gmail.com>
>>> wrote:
>>>
>>> On Tue, Dec 22, 2015 at 2:25 PM, Quinn Stevenson
>>> <qu...@pronoia-solutions.com> wrote:
>>>> Please forgive my ignorance here - but is Artemis the next major
>> version of ActiveMQ? Or is it something else?
>>>
>>> I would prefer to say It's a sub project of ActiveMQ. A different
>>> broker. We have been doing quite a lot of new development there.
>>> If you look at the history it was a donation of hornetq to apache as a
>>> sub project of activemq.
>>
>>
Re: JUnit Rule for Embedded Brokers
Posted by Christopher Shannon <ch...@gmail.com>.
It may need to go into a new subproject (as you pointed out, maybe under
tooling). While it could also just go into the activemq-unit-tests sub
project, there are unit tests in almost every sub project and it would be
nice if the JUnit Rule could be used in any of these projects. So, we'd
probably need to put it into a new tooling sub project and create a test
dependency for it.
On Tue, Dec 22, 2015 at 2:49 PM, Quinn Stevenson <
quinn@pronoia-solutions.com> wrote:
> Thank You for the information. I found the subproject on the ActiveMQ
> site, and I will be sure to get familiar with this.
>
> Since my needs are around JMS, I’ll work on a JUnit Rule for the Artemis
> EmbeddedJMS.
>
> Any suggestions on where to put the JUnit Rule for ActiveMQ 5.x in the
> source tree?
>
> > On Dec 22, 2015, at 12:40 PM, Clebert Suconic <cl...@gmail.com>
> wrote:
> >
> > On Tue, Dec 22, 2015 at 2:25 PM, Quinn Stevenson
> > <qu...@pronoia-solutions.com> wrote:
> >> Please forgive my ignorance here - but is Artemis the next major
> version of ActiveMQ? Or is it something else?
> >
> > I would prefer to say It's a sub project of ActiveMQ. A different
> > broker. We have been doing quite a lot of new development there.
> > If you look at the history it was a donation of hornetq to apache as a
> > sub project of activemq.
>
>
Re: JUnit Rule for Embedded Brokers
Posted by Quinn Stevenson <qu...@pronoia-solutions.com>.
Thank You for the information. I found the subproject on the ActiveMQ site, and I will be sure to get familiar with this.
Since my needs are around JMS, I’ll work on a JUnit Rule for the Artemis EmbeddedJMS.
Any suggestions on where to put the JUnit Rule for ActiveMQ 5.x in the source tree?
> On Dec 22, 2015, at 12:40 PM, Clebert Suconic <cl...@gmail.com> wrote:
>
> On Tue, Dec 22, 2015 at 2:25 PM, Quinn Stevenson
> <qu...@pronoia-solutions.com> wrote:
>> Please forgive my ignorance here - but is Artemis the next major version of ActiveMQ? Or is it something else?
>
> I would prefer to say It's a sub project of ActiveMQ. A different
> broker. We have been doing quite a lot of new development there.
> If you look at the history it was a donation of hornetq to apache as a
> sub project of activemq.
Re: JUnit Rule for Embedded Brokers
Posted by Clebert Suconic <cl...@gmail.com>.
On Tue, Dec 22, 2015 at 2:25 PM, Quinn Stevenson
<qu...@pronoia-solutions.com> wrote:
> Please forgive my ignorance here - but is Artemis the next major version of ActiveMQ? Or is it something else?
I would prefer to say It's a sub project of ActiveMQ. A different
broker. We have been doing quite a lot of new development there.
If you look at the history it was a donation of hornetq to apache as a
sub project of activemq.
Re: JUnit Rule for Embedded Brokers
Posted by Quinn Stevenson <qu...@pronoia-solutions.com>.
Please forgive my ignorance here - but is Artemis the next major version of ActiveMQ? Or is it something else?
I’d be happy to take a shot at a JUnit rule for Artemis, but I still would like to get the one for ActiveMQ 5.x into the community so I don’t have to keep copying it from project to project :-)
Quinn Stevenson
quinn@pronoia-solutions.com <ma...@pronoia-solutions.com>
> On Dec 22, 2015, at 12:17 PM, Clebert Suconic <cl...@gmail.com> wrote:
>
> Nice idea!
>
>
> If you can make one for Artemis, it would be here:
>
> https://github.com/apache/activemq-artemis/tree/master/artemis-commons/src/test/java/org/apache/activemq/artemis/utils
>
>
> but the embedding (coding to start it) is a bit different.
>
>
>
> On Tue, Dec 22, 2015 at 1:53 PM, Quinn Stevenson
> <qu...@pronoia-solutions.com> wrote:
>> All -
>>
>> I wrote a simple JUnit Rule to simplify setting up embedded ActiveMQ brokers for testing. I’ve been using it for some time now, and I find it very helpful.
>>
>> I would like to contribute the component to the ActiveMQ project and I’m planning on creating a pull request for it, but I need a little help with where a component like this belongs in the source tree. I was thinking of either adding it to the activemq-unit-tests module, or creating a module for it under activemq-tooling.
>>
>> Do either of these locations make sense? Or would another location/module be more appropriate?
>>
>> Quinn Stevenson
>> quinn@pronoia-solutions.com
>>
>>
>>
>
>
>
> --
> Clebert Suconic
Re: JUnit Rule for Embedded Brokers
Posted by Clebert Suconic <cl...@gmail.com>.
Nice idea!
If you can make one for Artemis, it would be here:
https://github.com/apache/activemq-artemis/tree/master/artemis-commons/src/test/java/org/apache/activemq/artemis/utils
but the embedding (coding to start it) is a bit different.
On Tue, Dec 22, 2015 at 1:53 PM, Quinn Stevenson
<qu...@pronoia-solutions.com> wrote:
> All -
>
> I wrote a simple JUnit Rule to simplify setting up embedded ActiveMQ brokers for testing. I’ve been using it for some time now, and I find it very helpful.
>
> I would like to contribute the component to the ActiveMQ project and I’m planning on creating a pull request for it, but I need a little help with where a component like this belongs in the source tree. I was thinking of either adding it to the activemq-unit-tests module, or creating a module for it under activemq-tooling.
>
> Do either of these locations make sense? Or would another location/module be more appropriate?
>
> Quinn Stevenson
> quinn@pronoia-solutions.com
>
>
>
--
Clebert Suconic