You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2025/07/30 18:26:35 UTC
[PR] Introduce new non-reserved keywords in the parser configs to preserve backward compatibility post Calcite upgrade [pinot]
yashmayya opened a new pull request, #16470:
URL: https://github.com/apache/pinot/pull/16470
- Fixes https://github.com/apache/pinot/issues/16295
- These new keywords were added in https://github.com/apache/pinot/pull/15263 but the non-reserved keywords list wasn't updated (note that we treat other type names like `INT`, `DOUBLE` etc. as non-reserved too).
- Note that `ASOF` and `MEASURE` aren't added here because similar to `JOIN`, `LEFT` etc. they need to be reserved in order for the SQL to be unambiguously parsed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Make UUID and VARIANT non-reserved keywords in the parser configs to preserve backward compatibility post Calcite upgrade [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #16470:
URL: https://github.com/apache/pinot/pull/16470#issuecomment-3138522248
Superseded by https://github.com/apache/pinot/pull/16471.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Make UUID and VARIANT non-reserved keywords in the parser configs to preserve backward compatibility post Calcite upgrade [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16470:
URL: https://github.com/apache/pinot/pull/16470#issuecomment-3137571328
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/16470?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.34%. Comparing base ([`4538997`](https://app.codecov.io/gh/apache/pinot/commit/45389974f6fad5a5f35b074d06063673112e8dc2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dfeb635`](https://app.codecov.io/gh/apache/pinot/commit/dfeb635cbae2dd25505a5829b703dbdae5ac90c0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (4538997) and HEAD (dfeb635). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (4538997) | HEAD (dfeb635) |
>|------|------|------|
>|unittests2|2|0|
>|unittests|3|1|
>|java-21|4|1|
>|temurin|9|1|
>|integration|6|0|
>|integration1|2|0|
>|java-11|5|0|
>|custom-integration1|2|0|
>|integration2|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16470 +/- ##
============================================
- Coverage 63.17% 56.34% -6.83%
+ Complexity 1361 699 -662
============================================
Files 3004 2350 -654
Lines 174098 129490 -44608
Branches 26641 20590 -6051
============================================
- Hits 109980 72960 -37020
+ Misses 55722 50517 -5205
+ Partials 8396 6013 -2383
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.34% <ø> (+23.16%)` | :arrow_up: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.34% <ø> (-6.83%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.34% <ø> (-6.83%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.34% <ø> (-0.02%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/16470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/16470?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Make UUID and VARIANT non-reserved keywords in the parser configs to preserve backward compatibility post Calcite upgrade [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #16470:
URL: https://github.com/apache/pinot/pull/16470#discussion_r2243672405
##########
pinot-common/src/main/codegen/config.fmpp:
##########
@@ -96,6 +96,7 @@ data: {
# "ARRAY_AGG" # not a keyword in Calcite
"ARRAY_MAX_CARDINALITY"
"AS"
+# "ASOF"
Review Comment:
This file is copied from Calcite babel `config.fmpp`. Seems these changes are not in the Calcite file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Make UUID and VARIANT non-reserved keywords in the parser configs to preserve backward compatibility post Calcite upgrade [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #16470:
URL: https://github.com/apache/pinot/pull/16470#discussion_r2243692691
##########
pinot-common/src/main/codegen/config.fmpp:
##########
@@ -96,6 +96,7 @@ data: {
# "ARRAY_AGG" # not a keyword in Calcite
"ARRAY_MAX_CARDINALITY"
"AS"
+# "ASOF"
Review Comment:
Did you go over the change log to find these new keyword?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Make UUID and VARIANT non-reserved keywords in the parser configs to preserve backward compatibility post Calcite upgrade [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on code in PR #16470:
URL: https://github.com/apache/pinot/pull/16470#discussion_r2244317950
##########
pinot-common/src/main/codegen/config.fmpp:
##########
@@ -96,6 +96,7 @@ data: {
# "ARRAY_AGG" # not a keyword in Calcite
"ARRAY_MAX_CARDINALITY"
"AS"
+# "ASOF"
Review Comment:
> This file is copied from Calcite babel config.fmpp. Seems these changes are not in the Calcite file
Yeah, oddly enough `VARIANT` and `UUID` are not present in this list either even though other types are - https://github.com/apache/calcite/blob/347664b4943ba0680cd5aa7af23405ca5bdde08a/babel/src/main/codegen/config.fmpp#L61. Probably a miss on the Calcite side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Make UUID and VARIANT non-reserved keywords in the parser configs to preserve backward compatibility post Calcite upgrade [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya closed pull request #16470: Make UUID and VARIANT non-reserved keywords in the parser configs to preserve backward compatibility post Calcite upgrade
URL: https://github.com/apache/pinot/pull/16470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org