You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ecoupal-believe (via GitHub)" <gi...@apache.org> on 2023/02/24 15:41:48 UTC

[GitHub] [apisix] ecoupal-believe opened a new pull request, #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

ecoupal-believe opened a new pull request, #8941:
URL: https://github.com/apache/apisix/pull/8941

   Add "redirect_after_logout_uri" to the oidc plugin to replace or override end_session_endpoint
   
   ### Description
   
   Add a missing field being used by resty oidc. Add the location where should the user be redirected after logout from the RP. This option overrides any end_session_endpoint that the OP may have provided in the discovery response.
   
   It fixes the issue where there is no "end_session_endpoint" defined in the openid-configuration of the provider eg AWS Cognito.
   
   Fixes # 6791
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] Sn0rt commented on pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

Posted by "Sn0rt (via GitHub)" <gi...@apache.org>.
Sn0rt commented on PR #8941:
URL: https://github.com/apache/apisix/pull/8941#issuecomment-1644858710

   take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] spacewander commented on pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on PR #8941:
URL: https://github.com/apache/apisix/pull/8941#issuecomment-1445539021

   @starsz 
   Please take a look when you have free time, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] starsz closed pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

Posted by "starsz (via GitHub)" <gi...@apache.org>.
starsz closed pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …
URL: https://github.com/apache/apisix/pull/8941


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] Sn0rt commented on pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

Posted by "Sn0rt (via GitHub)" <gi...@apache.org>.
Sn0rt commented on PR #8941:
URL: https://github.com/apache/apisix/pull/8941#issuecomment-1661730258

   @starsz can you close this one ? and I have create a new one for track.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] starsz commented on pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

Posted by "starsz (via GitHub)" <gi...@apache.org>.
starsz commented on PR #8941:
URL: https://github.com/apache/apisix/pull/8941#issuecomment-1446031051

   Hi @ecoupal-believe .
   Since the priority of `opts.redirect_after_logout_uri` is higher than `opts.discovery.end_session_endpoint`, so can you add a test case of "redirect_after_logout_uri" to ensure it works?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] starsz commented on pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

Posted by "starsz (via GitHub)" <gi...@apache.org>.
starsz commented on PR #8941:
URL: https://github.com/apache/apisix/pull/8941#issuecomment-1661732996

   > @starsz can you close this one ? and I have create a new one for track.
   
   OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] ecoupal-believe commented on pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

Posted by "ecoupal-believe (via GitHub)" <gi...@apache.org>.
ecoupal-believe commented on PR #8941:
URL: https://github.com/apache/apisix/pull/8941#issuecomment-1448255948

   Hi @starsz, I added the test case you wanted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] starsz commented on pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

Posted by "starsz (via GitHub)" <gi...@apache.org>.
starsz commented on PR #8941:
URL: https://github.com/apache/apisix/pull/8941#issuecomment-1455326789

   > Hi @starsz, I added the test case you wanted.
   
   Hi, @ecoupal-believe but CI failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org