You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Benjamin McCann (JIRA)" <ji...@apache.org> on 2007/10/08 23:40:38 UTC
[jira] Created: (WW-2235) Duplicate requests issued by browser
Duplicate requests issued by browser
------------------------------------
Key: WW-2235
URL: https://issues.apache.org/struts/browse/WW-2235
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.1.0
Environment: Firefox with the Firebug plugin
Reporter: Benjamin McCann
Assignee: Musachy Barroso
/struts/xhtml/validation.js and /struts/utils.js are requested twice in the page below.
<%@ taglib prefix="s" uri="/struts-tags"%>
<%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>Test</title>
<sx:head />
</head>
<body>
<s:form name="test" action="Test" validate="true">
</s:form>
</body>
</html>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2235) Duplicate requests issued by browser
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42391 ]
Musachy Barroso commented on WW-2235:
-------------------------------------
The dojo plugin needs these files for validation, the way I see it there are two ways of doing this:
1. always load the files on the dojo plugin (like now, duplicated request)
2. always load the files in the "head" tag on core (the files will be there even if js validation is not used, I think this one is worse)
can't think of anything else :(
> Duplicate requests issued by browser
> ------------------------------------
>
> Key: WW-2235
> URL: https://issues.apache.org/struts/browse/WW-2235
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.0
> Environment: Firefox with the Firebug plugin
> Reporter: Benjamin McCann
> Assignee: Musachy Barroso
>
> /struts/xhtml/validation.js and /struts/utils.js are requested twice in the page below.
> <%@ taglib prefix="s" uri="/struts-tags"%>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> <html>
> <head>
> <title>Test</title>
> <sx:head />
> </head>
> <body>
> <s:form name="test" action="Test" validate="true">
> </s:form>
> </body>
> </html>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2235) Duplicate requests issued by browser
Posted by "Benjamin McCann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42392 ]
Benjamin McCann commented on WW-2235:
-------------------------------------
Hmm. I'm not familiar enough with the code to make recommendations, but thought I'd make sure everyone was aware of the issue. Some possible thoughts:
Could the tags detect each other's presence and load the files only if not already loaded?
Perhaps an attribute could be added to one of the tags to make loading the JS optional?
> Duplicate requests issued by browser
> ------------------------------------
>
> Key: WW-2235
> URL: https://issues.apache.org/struts/browse/WW-2235
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.0
> Environment: Firefox with the Firebug plugin
> Reporter: Benjamin McCann
> Assignee: Musachy Barroso
>
> /struts/xhtml/validation.js and /struts/utils.js are requested twice in the page below.
> <%@ taglib prefix="s" uri="/struts-tags"%>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> <html>
> <head>
> <title>Test</title>
> <sx:head />
> </head>
> <body>
> <s:form name="test" action="Test" validate="true">
> </s:form>
> </body>
> </html>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2235) Duplicate requests issued by browser
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso resolved WW-2235.
---------------------------------
Resolution: Won't Fix
I don't see any way of fixing this, unless the form tag places something in the stack when validation is enabled, so the dojo plugin avoids requesting the same file. Considering that that file is a few bytes long, it will be cached, and this will happen only when js validation is enabled and dojo is used, I don't think it is worth the trouble.
> Duplicate requests issued by browser
> ------------------------------------
>
> Key: WW-2235
> URL: https://issues.apache.org/struts/browse/WW-2235
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Dojo Tags
> Affects Versions: 2.1.0
> Environment: Firefox with the Firebug plugin
> Reporter: Benjamin McCann
> Assignee: Musachy Barroso
> Fix For: 2.1.3
>
>
> /struts/xhtml/validation.js and /struts/utils.js are requested twice in the page below.
> <%@ taglib prefix="s" uri="/struts-tags"%>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> <html>
> <head>
> <title>Test</title>
> <sx:head />
> </head>
> <body>
> <s:form name="test" action="Test" validate="true">
> </s:form>
> </body>
> </html>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2235) Duplicate requests issued by browser
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2235:
--------------------------
Fix Version/s: (was: 2.1.4)
2.1.3
> Duplicate requests issued by browser
> ------------------------------------
>
> Key: WW-2235
> URL: https://issues.apache.org/struts/browse/WW-2235
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Dojo Tags
> Affects Versions: 2.1.0
> Environment: Firefox with the Firebug plugin
> Reporter: Benjamin McCann
> Assignee: Musachy Barroso
> Fix For: 2.1.3
>
>
> /struts/xhtml/validation.js and /struts/utils.js are requested twice in the page below.
> <%@ taglib prefix="s" uri="/struts-tags"%>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> <html>
> <head>
> <title>Test</title>
> <sx:head />
> </head>
> <body>
> <s:form name="test" action="Test" validate="true">
> </s:form>
> </body>
> </html>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2235) Duplicate requests issued by browser
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44397#action_44397 ]
Musachy Barroso commented on WW-2235:
-------------------------------------
I don't see any way of fixing this, unless the form tag places something in the stack when validation is enabled, so the dojo plugin avoids requesting the same file. Considering that that file is a few bytes long, it will be cached, and this will happen only when js validation is enabled and dojo is used, I don't think it is worth the trouble.
> Duplicate requests issued by browser
> ------------------------------------
>
> Key: WW-2235
> URL: https://issues.apache.org/struts/browse/WW-2235
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Dojo Tags
> Affects Versions: 2.1.0
> Environment: Firefox with the Firebug plugin
> Reporter: Benjamin McCann
> Assignee: Musachy Barroso
> Fix For: 2.1.3
>
>
> /struts/xhtml/validation.js and /struts/utils.js are requested twice in the page below.
> <%@ taglib prefix="s" uri="/struts-tags"%>
> <%@ taglib prefix="sx" uri="/struts-dojo-tags" %>
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> <html>
> <head>
> <title>Test</title>
> <sx:head />
> </head>
> <body>
> <s:form name="test" action="Test" validate="true">
> </s:form>
> </body>
> </html>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.