[jira] [Commented] (SVN-3744) Use distinct names for all format files

["Daniel Shahaf (äñ§€¥£¢ JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SVN-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112937#comment-16112937 ] 

Daniel Shahaf (äñ§€¥£¢) commented on SVN-3744:
----------------------------------------------

See r1804013 for another form of this.

That revision demonstrates an issue of independent interest: svn_fs_type() defaults to bdb when there's no "fs-type" file, so _any_ directory with a "format" file (whose value is smaller than SVN_FS_BASE__FORMAT_NUMBER) will be accepted by svn_fs_open().

> Use distinct names for all format files
> ---------------------------------------
>
>                 Key: SVN-3744
>                 URL: https://issues.apache.org/jira/browse/SVN-3744
>             Project: Subversion
>          Issue Type: Task
>          Components: libsvn_repos
>    Affects Versions: all
>            Reporter: Daniel Shahaf (äñ§€¥£¢)
>             Fix For: 2.0-consider
>
>
> {noformat:nopanel=true}
> A Subversion repository contains a file named 'format' (whose contents is
> SVN_REPOS__FORMAT_NUMBER) and a file named 'db/format' (whose contents is the
> filesystem format, and potentially some additional FS-backend-dependent
> information).
> Users commonly confuse the two when asked to report the contents of one of them.
>  svnadmin is confused by this, too (which typically manifests as a cryptic error
> message from the invocation 'svnadmin /path/to/repos/db' --- which, yes, is bogus).
> At the next opportunity, we should rename these files to have distinct basenames
> --- for example, $REPOS/repos-format and $REPOS/db/fs-format.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)