You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Bowrna (via GitHub)" <gi...@apache.org> on 2023/02/26 05:05:56 UTC
[GitHub] [airflow] Bowrna opened a new pull request, #29773: better description for limit in api
Bowrna opened a new pull request, #29773:
URL: https://github.com/apache/airflow/pull/29773
I have made changes in config.yml file with better description for maximum page limit and fallback page limit
closes: #27425
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29773: better description for limit in api
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29773:
URL: https://github.com/apache/airflow/pull/29773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #29773: better description for limit in api
Posted by "Bowrna (via GitHub)" <gi...@apache.org>.
Bowrna commented on PR #29773:
URL: https://github.com/apache/airflow/pull/29773#issuecomment-1445415369
> I agree it was confusing and the way it is described now is vey accurate. Thanks @Bowrna for that.
>
> Additionally - maybe that would be an option to consider as a follow-up we could print (if not already done) warning in webserver's logs in case someone uses page limit higher than maximum? This way there would be at least an indication in the logs that someone is doing something not really expected and the admins of Airflow could potentially warn the user of the API about it.
yes completely agree with you on this point @potiuk There is high chance for user to miss out reading the description. Throwing this information in the logs is the best way to prevent such confusion. I will do that part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29773: better description for limit in api
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29773:
URL: https://github.com/apache/airflow/pull/29773#issuecomment-1445400834
I agree it was confusing and the way it is described now is vey accurate. Thanks @bowrna for that.
Additionally - maybe that would be an option to consider as a follow-up we could print (if not already done) warning in webserver's logs in case someone uses page limit higher than maximum? This way there would be at least an indication in the logs that someone is doing something not really expected and the admins of Airflow could potentially warn the user of the API about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org