You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "PickBas (via GitHub)" <gi...@apache.org> on 2023/05/31 11:18:26 UTC
[GitHub] [eventmesh] PickBas opened a new pull request, #4056: [ISSUE #4019][Enhancement] Code optimization.[SubStreamHandler]
PickBas opened a new pull request, #4056:
URL: https://github.com/apache/eventmesh/pull/4056
Fixes #4019.
### Modifications
1. [Implemented Serializable](https://github.com/apache/eventmesh/commit/714354bc3beaba75d0089ce3480b248eb97e5e0f)
2. [Objects.requireNonNull for getTopic()](https://github.com/apache/eventmesh/commit/931c2ab857d5c4d92b84c1a91056e82d7ac5adb4)
3. [Interrupted currentThread on InterruptedException](https://github.com/apache/eventmesh/commit/8d1cbf0cefb910214b02d74a78de8bdd8d4238c0)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4019][Enhancement] Code optimization.[SubStreamHandler] (eventmesh)
Posted by "weihubeats (via GitHub)" <gi...@apache.org>.
weihubeats merged PR #4056:
URL: https://github.com/apache/eventmesh/pull/4056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #4056: [ISSUE #4019][Enhancement] Code optimization.[SubStreamHandler]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4056:
URL: https://github.com/apache/eventmesh/pull/4056#issuecomment-1576677257
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4056?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4056](https://app.codecov.io/gh/apache/eventmesh/pull/4056?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7dad90f) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/fb144bb1d0d838ef2a4d1cccc2bd7877bd4ab09f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fb144bb) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 7dad90f differs from pull request most recent head e86e249. Consider uploading reports for the commit e86e249 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4056 +/- ##
============================================
- Coverage 14.22% 14.22% -0.01%
Complexity 1328 1328
============================================
Files 580 580
Lines 28856 28857 +1
Branches 2792 2792
============================================
Hits 4105 4105
- Misses 24361 24362 +1
Partials 390 390
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4056?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...entmesh/client/grpc/consumer/SubStreamHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/4056?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvY29uc3VtZXIvU3ViU3RyZWFtSGFuZGxlci5qYXZh) | `46.51% <0.00%> (-0.55%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org