[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41173: [SPARK-43510][YARN] Fix YarnAllocator internal state when adding running executor after processing completed containers

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #41173:
URL: https://github.com/apache/spark/pull/41173#discussion_r1197416999


##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala:
##########
@@ -806,11 +796,31 @@ private[yarn] class YarnAllocator(
     }
   }
 
+  // visible for testing

Review Comment:
   nit. Could you try to use `PrivateMethodTester`? Here is an example, cfd42355ccbdf34ca9bd5a125c4310b9da14100c



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org