You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/13 13:53:00 UTC

[jira] [Commented] (AIRFLOW-5623) latest_only_operator fails for schedule_interval='@once'

    [ https://issues.apache.org/jira/browse/AIRFLOW-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950325#comment-16950325 ] 

ASF GitHub Bot commented on AIRFLOW-5623:
-----------------------------------------

SaturnFromTitan commented on pull request #6320: [AIRFLOW-5623]: attempt to add a failing test
URL: https://github.com/apache/airflow/pull/6320
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5623
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> latest_only_operator fails for schedule_interval='@once'
> --------------------------------------------------------
>
>                 Key: AIRFLOW-5623
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5623
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.5
>            Reporter: Gerben Oostra
>            Assignee: Martin Winkel
>            Priority: Minor
>
> Observation: In a dag with schedule_interval set to @once, the `latest_only_operator` fails with the following error:
>  
> {{[2019-10-09 09:51:37,346] \{latest_only_operator.py:48} INFO - Checking latest only with left_window: None right_window: None now: 2019-10-09 07:51:37.346697+00:00
> [2019-10-09 09:51:37,347] \{models.py:1736} ERROR - '<' not supported between instances of 'NoneType' and 'datetime.datetime'
> Traceback (most recent call last):
>   File "/XXXX/anaconda/envs/airflow/lib/python3.6/site-packages/airflow/models.py", line 1633, in _run_raw_task
>     result = task_copy.execute(context=context)
>   File "/XXXX/anaconda/envs/airflow/lib/python3.6/site-packages/airflow/operators/latest_only_operator.py", line 51, in execute
>     if not left_window < now <= right_window:
> TypeError: '<' not supported between instances of 'NoneType' and 'datetime.datetime'
> [2019-10-09 09:51:37,363] \{models.py:1756} INFO - Marking task as UP_FOR_RETRY}}
> I expected it to succeed, and allow the remainder of the dag to be ran. (if an @once dag is running, it is always the latest)
> Rootcause analysis:
> If the `schedule_interval` of a dag is `@once`, the dag's field `self._schedule_interval` is set to `None`.
> The `latest_only_operator` determines the window by passing the execution date to the dags `following_schedule()`. There the dag's `self._schedule_interval` type is compared to `six.string_types` and `timedelta`. Both type checks fail, so nothing (`None`) is returned.
> Causing the time window comparison to fail.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)