[GitHub] [skywalking] wu-sheng commented on a change in pull request #3560: Provide Consul dynamic configuration center implementation

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #3560: Provide Consul dynamic configuration center implementation
URL: https://github.com/apache/skywalking/pull/3560#discussion_r331515278
 
 

 ##########
 File path: docs/en/setup/backend/dynamic-config.md
 ##########
 @@ -94,8 +94,20 @@ configuration:
     clusterName: "default"
 ```
 
+## Dynamic Configuration Consul Implementation
+
+[Consul](https://github.com/rickfast/consul-client) is also supported as DCC(Dynamic Configuration Center), to use it, please configure as follows:
+
+```yaml
+configuration:
+  consul:
+    # Consul host and ports, separated by comma, e.g. 1.2.3.4:8500,2.3.4.5:8500
+    hostAndPorts: 127.0.0.1:8500
+    # Sync period in seconds. Defaults to 60 seconds.
+    period: 60
+```
+
 ## 3rd party Configuration Center
-We are welcome contributions to implement this module provider to support popular configuration center, 
-such as Consul. Submit issue to discuss.
+We are welcome contributions to implement this module provider to support popular configuration center. Submit issue to discuss.
 
 Review comment:
   We should remove this, I think we have all popular configuration center from this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services