You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/04/01 04:08:33 UTC

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
-----------------------------------------------------------

(Updated April 1, 2016, 2:08 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebase.


Bugs: MESOS-5041
    https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
-------

Enable cgroups unified isolator in isolation.


Diffs (updated)
-----

  src/CMakeLists.txt 366a7ae8f6ef1d55202699df0502a30f15a35e1f 
  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/containerizer.cpp a5dd22380066aa85de04d485052084e2629681c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45086: Enable cgroups unified isolator in isolation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/#review129244
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45083, 45084, 46043, 45085, 46158, 45087, 45352, 45362, 46299, 45363, 45472, 45573, 45574, 43284, 46300, 45086]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 16, 2016, 10:29 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45086/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable cgroups unified isolator in isolation.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0 
> 
> Diff: https://reviews.apache.org/r/45086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 45086: Enable cgroups unified isolator in isolation.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
-----------------------------------------------------------

(Updated April 16, 2016, 10:29 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, Jie Yu, and Kevin Klues.


Changes
-------

Rebase.


Bugs: MESOS-5041
    https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
-------

Enable cgroups unified isolator in isolation.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45086: Enable cgroups unified isolator in isolation.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
-----------------------------------------------------------

(Updated April 16, 2016, 10:24 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, Jie Yu, and Kevin Klues.


Changes
-------

Rebase.


Bugs: MESOS-5041
    https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
-------

Enable cgroups unified isolator in isolation.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45086: Enable cgroups unified isolator in isolation.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
-----------------------------------------------------------

(Updated April 16, 2016, 10:14 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, Jie Yu, and Kevin Klues.


Bugs: MESOS-5041
    https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
-------

Enable cgroups unified isolator in isolation.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45086: Enable cgroups unified isolator in isolation.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
-----------------------------------------------------------

(Updated April 10, 2016, 2:43 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, Jie Yu, and Kevin Klues.


Changes
-------

Fix compile error in OS X and windows.


Bugs: MESOS-5041
    https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
-------

Enable cgroups unified isolator in isolation.


Diffs (updated)
-----

  src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
  src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa 
  src/slave/containerizer/mesos/containerizer.cpp c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45086: Enable cgroups unified isolator in isolation.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
-----------------------------------------------------------

(Updated April 7, 2016, 10:38 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, Jie Yu, and Kevin Klues.


Changes
-------

Rebase.


Bugs: MESOS-5041
    https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
-------

Enable cgroups unified isolator in isolation.


Diffs (updated)
-----

  src/CMakeLists.txt 9a4cffa952a452d5df70ea42949142e534067cd6 
  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/slave/containerizer/mesos/containerizer.cpp a5dd22380066aa85de04d485052084e2629681c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45086: Enable cgroups unified isolator in isolation.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
-----------------------------------------------------------

(Updated April 4, 2016, 5:17 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, Jie Yu, and Kevin Klues.


Changes
-------

Rebase and update reviewers.


Bugs: MESOS-5041
    https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
-------

Enable cgroups unified isolator in isolation.


Diffs (updated)
-----

  src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/containerizer.cpp a5dd22380066aa85de04d485052084e2629681c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
-------


Thanks,

haosdent huang