You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by darchons <gi...@git.apache.org> on 2018/06/06 02:38:00 UTC
[GitHub] guacamole-client pull request #295: GUACAMOLE-565: Add en translations for t...
GitHub user darchons opened a pull request:
https://github.com/apache/guacamole-client/pull/295
GUACAMOLE-565: Add en translations for terminal-type parameter.
Follow-up to #288. Add en translations for the terminal-type parameter and its enum values. Also add an empty value to the terminal-type enum lists.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/darchons/guacamole-client guac-565-add-terminal-type-parameter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #295
----
commit 62d617f278426f870a55a35160a554532554ca52
Author: Jim Chen <nc...@...>
Date: 2018-06-06T02:33:50Z
GUACAMOLE-565: Add en translations for terminal-type parameter.
Add en translations for the terminal-type parameter and its enum values.
Also add an empty value to the terminal-type enum lists.
----
---
[GitHub] guacamole-client pull request #295: GUACAMOLE-565: Add en translations for t...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/295#discussion_r193361671
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -536,6 +546,14 @@
"FIELD_OPTION_FONT_SIZE_96" : "96",
"FIELD_OPTION_FONT_SIZE_EMPTY" : "",
+ "FIELD_OPTION_TERMINAL_TYPE_EMPTY" : "",
+ "FIELD_OPTION_TERMINAL_TYPE_XTERM" : "xterm",
+ "FIELD_OPTION_TERMINAL_TYPE_XTERM_256COLOR" : "xterm-256color",
+ "FIELD_OPTION_TERMINAL_TYPE_VT220" : "vt220",
+ "FIELD_OPTION_TERMINAL_TYPE_VT100" : "vt100",
+ "FIELD_OPTION_TERMINAL_TYPE_ANSI" : "ansi",
+ "FIELD_OPTION_TERMINAL_TYPE_LINUX" : "linux",
--- End diff --
As mentioned above - for style consistency, please line up the ":" in this group of options.
---
[GitHub] guacamole-client pull request #295: GUACAMOLE-565: Add en translations for t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-client/pull/295
---
[GitHub] guacamole-client pull request #295: GUACAMOLE-565: Add en translations for t...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/295#discussion_r193361549
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -475,6 +476,14 @@
"FIELD_OPTION_FONT_SIZE_96" : "96",
"FIELD_OPTION_FONT_SIZE_EMPTY" : "",
+ "FIELD_OPTION_TERMINAL_TYPE_EMPTY" : "",
+ "FIELD_OPTION_TERMINAL_TYPE_XTERM" : "xterm",
+ "FIELD_OPTION_TERMINAL_TYPE_XTERM_256COLOR" : "xterm-256color",
+ "FIELD_OPTION_TERMINAL_TYPE_VT220" : "vt220",
+ "FIELD_OPTION_TERMINAL_TYPE_VT100" : "vt100",
+ "FIELD_OPTION_TERMINAL_TYPE_ANSI" : "ansi",
+ "FIELD_OPTION_TERMINAL_TYPE_LINUX" : "linux",
--- End diff --
This is a style nitpick, but in keeping with the style used throughout the rest of these JSON files, if there are a group of objects like this, the ":" should be lined up in the same column.
---