You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "Yikf (via GitHub)" <gi...@apache.org> on 2023/04/07 02:45:21 UTC
[GitHub] [kyuubi] Yikf commented on a diff in pull request #4585: Authz policy file gen
Yikf commented on code in PR #4585:
URL: https://github.com/apache/kyuubi/pull/4585#discussion_r1160396448
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -331,4 +331,38 @@
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
</build>
+ <profiles>
+ <profile>
+ <id>genpolicy</id>
+ <activation>
+ <property>
+ <name>ranger.version</name>
+ <value>2.3.0</value>
+ </property>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
Review Comment:
Just out of curiosity, Why do we need this plugin?
`src/test/gen/scala` should place the golden file instead of the source.
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -331,4 +331,38 @@
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
</build>
+ <profiles>
+ <profile>
+ <id>genpolicy</id>
+ <activation>
+ <property>
+ <name>ranger.version</name>
Review Comment:
Why do we need this property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org