You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/16 14:38:40 UTC

[GitHub] [fineract-cn-mobile] EGOR-IND commented on a change in pull request #140: Fix 272: Phone and Mobile bug fixed in Customer Contract Fragment

EGOR-IND commented on a change in pull request #140:
URL: https://github.com/apache/fineract-cn-mobile/pull/140#discussion_r595231823



##########
File path: app/src/main/res/layout/fragment_form_customer_contact.xml
##########
@@ -75,7 +75,8 @@
                         <EditText
                             android:hint="@string/optional_mobile"
                             android:id="@+id/et_mobile"
-                            android:inputType="text"
+                            android:inputType="number"
+                            android:maxLength="10"

Review comment:
       @PatelVatsalB21 If I'm not wrong then there is no international limit of phone number length. Actually phone number length vary from region to region. So limiting the length to 10 wouldn't be good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org