You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Felix Schumacher <fe...@internetallee.de> on 2017/02/11 16:45:26 UTC

Re: svn commit: r1782609 - in /jmeter/trunk: bin/user.properties xdocs/usermanual/generating-dashboard.xml


Am 11. Februar 2017 16:15:15 MEZ schrieb pmouawad@apache.org:
>Author: pmouawad
>Date: Sat Feb 11 15:15:14 2017
>New Revision: 1782609
>
>URL: http://svn.apache.org/viewvc?rev=1782609&view=rev
>Log:
>Improve regex to allow better filtering
>
>Modified:
>    jmeter/trunk/bin/user.properties
>    jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
>
>Modified: jmeter/trunk/bin/user.properties
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/bin/user.properties?rev=1782609&r1=1782608&r2=1782609&view=diff
>==============================================================================
>--- jmeter/trunk/bin/user.properties (original)
>+++ jmeter/trunk/bin/user.properties Sat Feb 11 15:15:14 2017
>@@ -89,10 +89,10 @@
> 
> # Indicates which graph series are filtered (regular expression)
> # In the below example we filter on Search and Order samples
>-# Note that the end of the pattern should always include
>(-success|-failure)? 
>+# Note that the end of the pattern should always include
>((-success$|-failure$)|$)
># TransactionsPerSecondGraphConsumer suffixes transactions with
>"-success" or "-failure" depending 
> # on the result
>-#jmeter.reportgenerator.exporter.html.series_filter=(Search|Order)(-success|-failure)?
>+#jmeter.reportgenerator.exporter.html.series_filter=((^Search)|(^Order))((-success$|-failure$)|$)

^(a|b)(-(a|b))?$

would be shorter, but it would be even shorter, if you use match instead of find, when applying the regex.

Regards,
Felix

> 
># Indicates whether only controller samples are displayed on graphs
>that support it.
> #jmeter.reportgenerator.exporter.html.show_controllers_only=false
>
>Modified: jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/generating-dashboard.xml?rev=1782609&r1=1782608&r2=1782609&view=diff
>==============================================================================
>--- jmeter/trunk/xdocs/usermanual/generating-dashboard.xml (original)
>+++ jmeter/trunk/xdocs/usermanual/generating-dashboard.xml Sat Feb 11
>15:15:14 2017
>@@ -286,7 +286,7 @@ jmeter.save.saveservice.timestamp_format
>                                 Default: <code>true</code></property>
>           <property name="series_filter" required="No">Sets the filter
>                   of series. An empty value deactivates the filtering.
>-                                If not empty, regex should end with
><code>(-success|-failure)?</code><br/>
>+                                If not empty, regex should end with
><code>((-success$|-failure$)|$)</code><br/>
>                                 Format: regular expression.
>                                 Default: ""
>                             </property>

Re: svn commit: r1782609 - in /jmeter/trunk: bin/user.properties xdocs/usermanual/generating-dashboard.xml

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 11.02.2017 um 17:49 schrieb Philippe Mouawad:
> On Saturday, February 11, 2017, Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>>
>> Am 11. Februar 2017 16:15:15 MEZ schrieb pmouawad@apache.org
>> <javascript:;>:
>>> Author: pmouawad
>>> Date: Sat Feb 11 15:15:14 2017
>>> New Revision: 1782609
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1782609&view=rev
>>> Log:
>>> Improve regex to allow better filtering
>>>
>>> Modified:
>>>     jmeter/trunk/bin/user.properties
>>>     jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
>>>
>>> Modified: jmeter/trunk/bin/user.properties
>>> URL:
>>> http://svn.apache.org/viewvc/jmeter/trunk/bin/user.
>> properties?rev=1782609&r1=1782608&r2=1782609&view=diff
>>> ===========================================================
>> ===================
>>> --- jmeter/trunk/bin/user.properties (original)
>>> +++ jmeter/trunk/bin/user.properties Sat Feb 11 15:15:14 2017
>>> @@ -89,10 +89,10 @@
>>>
>>> # Indicates which graph series are filtered (regular expression)
>>> # In the below example we filter on Search and Order samples
>>> -# Note that the end of the pattern should always include
>>> (-success|-failure)?
>>> +# Note that the end of the pattern should always include
>>> ((-success$|-failure$)|$)
>>> # TransactionsPerSecondGraphConsumer suffixes transactions with
>>> "-success" or "-failure" depending
>>> # on the result
>>> -#jmeter.reportgenerator.exporter.html.series_filter=(
>> Search|Order)(-success|-failure)?
>>> +#jmeter.reportgenerator.exporter.html.series_filter=((
>> ^Search)|(^Order))((-success$|-failure$)|$)
>>
>> ^(a|b)(-(a|b))?$
>>
>> would be shorter, but it would be even shorter, if you use match instead
>> of find, when applying the regex.
> It's a java and javascript used regex.
> If your remark on findxapplies for both go ahead.
RegExp#test is more like a find, so it would not work straight out of 
the box, but you could apply "^"+filter+"$" in the constructor of the 
RegExp.

Felix

> Thanks
>
>> Regards,
>> Felix
>>
>>> # Indicates whether only controller samples are displayed on graphs
>>> that support it.
>>> #jmeter.reportgenerator.exporter.html.show_controllers_only=false
>>>
>>> Modified: jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
>>> URL:
>>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/
>> generating-dashboard.xml?rev=1782609&r1=1782608&r2=1782609&view=diff
>>> ===========================================================
>> ===================
>>> --- jmeter/trunk/xdocs/usermanual/generating-dashboard.xml (original)
>>> +++ jmeter/trunk/xdocs/usermanual/generating-dashboard.xml Sat Feb 11
>>> 15:15:14 2017
>>> @@ -286,7 +286,7 @@ jmeter.save.saveservice.timestamp_format
>>>                                  Default: <code>true</code></property>
>>>            <property name="series_filter" required="No">Sets the filter
>>>                    of series. An empty value deactivates the filtering.
>>> -                                If not empty, regex should end with
>>> <code>(-success|-failure)?</code><br/>
>>> +                                If not empty, regex should end with
>>> <code>((-success$|-failure$)|$)</code><br/>
>>>                                  Format: regular expression.
>>>                                  Default: ""
>>>                              </property>
>


Re: svn commit: r1782609 - in /jmeter/trunk: bin/user.properties xdocs/usermanual/generating-dashboard.xml

Posted by Philippe Mouawad <ph...@gmail.com>.
On Saturday, February 11, 2017, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
>
> Am 11. Februar 2017 16:15:15 MEZ schrieb pmouawad@apache.org
> <javascript:;>:
> >Author: pmouawad
> >Date: Sat Feb 11 15:15:14 2017
> >New Revision: 1782609
> >
> >URL: http://svn.apache.org/viewvc?rev=1782609&view=rev
> >Log:
> >Improve regex to allow better filtering
> >
> >Modified:
> >    jmeter/trunk/bin/user.properties
> >    jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
> >
> >Modified: jmeter/trunk/bin/user.properties
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/bin/user.
> properties?rev=1782609&r1=1782608&r2=1782609&view=diff
> >===========================================================
> ===================
> >--- jmeter/trunk/bin/user.properties (original)
> >+++ jmeter/trunk/bin/user.properties Sat Feb 11 15:15:14 2017
> >@@ -89,10 +89,10 @@
> >
> > # Indicates which graph series are filtered (regular expression)
> > # In the below example we filter on Search and Order samples
> >-# Note that the end of the pattern should always include
> >(-success|-failure)?
> >+# Note that the end of the pattern should always include
> >((-success$|-failure$)|$)
> ># TransactionsPerSecondGraphConsumer suffixes transactions with
> >"-success" or "-failure" depending
> > # on the result
> >-#jmeter.reportgenerator.exporter.html.series_filter=(
> Search|Order)(-success|-failure)?
> >+#jmeter.reportgenerator.exporter.html.series_filter=((
> ^Search)|(^Order))((-success$|-failure$)|$)
>
> ^(a|b)(-(a|b))?$
>
> would be shorter, but it would be even shorter, if you use match instead
> of find, when applying the regex.

It's a java and javascript used regex.
If your remark on findxapplies for both go ahead.
Thanks

>
> Regards,
> Felix
>
> >
> ># Indicates whether only controller samples are displayed on graphs
> >that support it.
> > #jmeter.reportgenerator.exporter.html.show_controllers_only=false
> >
> >Modified: jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/
> generating-dashboard.xml?rev=1782609&r1=1782608&r2=1782609&view=diff
> >===========================================================
> ===================
> >--- jmeter/trunk/xdocs/usermanual/generating-dashboard.xml (original)
> >+++ jmeter/trunk/xdocs/usermanual/generating-dashboard.xml Sat Feb 11
> >15:15:14 2017
> >@@ -286,7 +286,7 @@ jmeter.save.saveservice.timestamp_format
> >                                 Default: <code>true</code></property>
> >           <property name="series_filter" required="No">Sets the filter
> >                   of series. An empty value deactivates the filtering.
> >-                                If not empty, regex should end with
> ><code>(-success|-failure)?</code><br/>
> >+                                If not empty, regex should end with
> ><code>((-success$|-failure$)|$)</code><br/>
> >                                 Format: regular expression.
> >                                 Default: ""
> >                             </property>
>


-- 
Cordialement.
Philippe Mouawad.