You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/02 19:58:26 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #6356: Independent schema is set for each consumer generated by topic

sijie commented on a change in pull request #6356: Independent schema is set for each consumer generated by topic
URL: https://github.com/apache/pulsar/pull/6356#discussion_r386617283
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AutoConsumeSchema.java
 ##########
 @@ -132,6 +132,11 @@ public void configureSchemaInfo(String topicName,
         }
     }
 
+    @Override
+    public Schema<GenericRecord> cloneSchema() {
+        return Schema.AUTO_CONSUME();
 
 Review comment:
   I understand it can be changed. but `cloneSchema` is cloning a schema, we should copy the fields when cloning a schema.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services