You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kan Zhang (JIRA)" <ji...@apache.org> on 2010/11/10 01:05:08 UTC
[jira] Created: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Adding a test method to support the testing of fetchdt tool
-----------------------------------------------------------
Key: HADOOP-7024
URL: https://issues.apache.org/jira/browse/HADOOP-7024
Project: Hadoop Common
Issue Type: Test
Reporter: Kan Zhang
Attachments: c1178-03.patch
It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-7024:
------------------------------
Status: Open (was: Patch Available)
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-7024:
------------------------------
Attachment: c1178-04.patch
Cos, thanks for your suggestion. I'm attaching a new patch to address it. Please review.
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-7024:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Assignee: Kan Zhang
Status: Resolved (was: Patch Available)
I've committed this. Resolving as fixed. Thanks, Kan!
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 0.22.0
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-7024:
--------------------------------
Hadoop Flags: [Reviewed]
Great suggestion Cos. +1 on the patch.
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7024) Create a test method for adding
file systems during tests.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931366#action_12931366 ]
Hudson commented on HADOOP-7024:
--------------------------------
Integrated in Hadoop-Common-trunk #510 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/510/])
HADOOP-7024. Create a test method for adding file systems during tests. Contributed by Kan Zhang.
> Create a test method for adding file systems during tests.
> ----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 0.22.0
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7024) Create a test method for adding file
systems during tests.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-7024:
--------------------------------
Component/s: test
Affects Version/s: 0.22.0
Summary: Create a test method for adding file systems during tests. (was: Adding a test method to support the testing of fetchdt tool)
> Create a test method for adding file systems during tests.
> ----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 0.22.0
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931226#action_12931226 ]
Hadoop QA commented on HADOOP-7024:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459385/c1178-04.patch
against trunk revision 1033812.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//console
This message is automatically generated.
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930392#action_12930392 ]
Kan Zhang commented on HADOOP-7024:
-----------------------------------
It's an internal method for unit testing only and will be used by TestDelegationTokenFetcher in HDFS.
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7024) Create a test method for adding
file systems during tests.
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931332#action_12931332 ]
Konstantin Boudnik commented on HADOOP-7024:
--------------------------------------------
Sorry, missed the comments - patch looks great! Thanks Kan.
> Create a test method for adding file systems during tests.
> ----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 0.22.0
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-7024:
------------------------------
Status: Patch Available (was: Open)
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7024) Create a test method for adding
file systems during tests.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931473#action_12931473 ]
Hudson commented on HADOOP-7024:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #422 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/422/])
> Create a test method for adding file systems during tests.
> ----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 0.22.0
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1178-03.patch, c1178-04.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930847#action_12930847 ]
Konstantin Boudnik commented on HADOOP-7024:
--------------------------------------------
Would it be more appropriate to have this potentially dangerous method to have a package private visibility and then add a public wrapper in a test utility class?
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930387#action_12930387 ]
Hadoop QA commented on HADOOP-7024:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459200/c1178-03.patch
against trunk revision 1032730.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//console
This message is automatically generated.
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-7024:
------------------------------
Attachment: c1178-03.patch
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7024) Adding a test method to support the
testing of fetchdt tool
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-7024:
------------------------------
Status: Patch Available (was: Open)
> Adding a test method to support the testing of fetchdt tool
> -----------------------------------------------------------
>
> Key: HADOOP-7024
> URL: https://issues.apache.org/jira/browse/HADOOP-7024
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Kan Zhang
> Attachments: c1178-03.patch
>
>
> It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.