You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/14 08:36:35 UTC
[GitHub] [spark] Gschiavon opened a new pull request #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Gschiavon opened a new pull request #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578
### What changes were proposed in this pull request?
The only change is that I've added a column check when using insertInto. Now it checks that the query dataFrame has the same column names as the target table.
### Why are the changes needed?
They are needed because it helps a lot when you have a lot of columns, and if you have one missing the current message doesn't tell you which one.
Also insertInto just check that the number of columns of both are the same, but not the order or anything.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
I added a test case just to show the new behaviour, obviously there will be more test added depending on the comments
Jira -> https://issues.apache.org/jira/browse/SPARK-30828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Gschiavon removed a comment on issue #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Posted by GitBox <gi...@apache.org>.
Gschiavon removed a comment on issue #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578#issuecomment-588630041
ping @cloud-fan @HyukjinKwon
Let me know what do you think about this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578#issuecomment-586154456
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578#issuecomment-586154456
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578#issuecomment-586155095
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578#issuecomment-586155095
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Gschiavon commented on issue #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Posted by GitBox <gi...@apache.org>.
Gschiavon commented on issue #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578#issuecomment-593260363
ping @cloud-fan @HyukjinKwon @dongjoon-hyun
Hi! what do you think about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578#issuecomment-588264624
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Gschiavon commented on issue #27578:
[WIP][SPARK-30828][SQL] Improving insertInto behaviour
Posted by GitBox <gi...@apache.org>.
Gschiavon commented on issue #27578: [WIP][SPARK-30828][SQL] Improving insertInto behaviour
URL: https://github.com/apache/spark/pull/27578#issuecomment-588630041
ping @cloud-fan @HyukjinKwon
Let me know what do you think about this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org