You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 13:38:38 UTC

[GitHub] [flink] rmetzger opened a new pull request #12175: [FLINK-17692] Keep yarn.classpath in target folder to not pollute local builds

rmetzger opened a new pull request #12175:
URL: https://github.com/apache/flink/pull/12175


   ## What is the purpose of the change
   
   Before this change, git was showing the an untracked file in `flink-end-to-end-tests/test-scripts/hadoop/yarn.classpath`.
   
   ## Brief change log
   
     - Get the yarn.classpath file from `flink-yarn-tests/target`.
   
   
   
   ## Verifying this change
   
   I tested the change here: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=8002&view=results
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger merged pull request #12175: [FLINK-17692] Keep yarn.classpath in target folder to not pollute local builds

Posted by GitBox <gi...@apache.org>.

rmetzger merged pull request #12175:
URL: https://github.com/apache/flink/pull/12175


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12175: [FLINK-17692] Keep yarn.classpath in target folder to not pollute local builds

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12175:
URL: https://github.com/apache/flink/pull/12175#issuecomment-629242592

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit ce58cc723cd8918dd52cf14a89808b0999d128bc (Fri Oct 16 10:36:20 UTC 2020)

**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12175: [FLINK-17692] Keep yarn.classpath in target folder to not pollute local builds

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12175:
URL: https://github.com/apache/flink/pull/12175#issuecomment-629242592

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit ce58cc723cd8918dd52cf14a89808b0999d128bc (Fri May 15 13:41:35 UTC 2020)

**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12175: [FLINK-17692] Keep yarn.classpath in target folder to not pollute local builds

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12175:
URL: https://github.com/apache/flink/pull/12175#issuecomment-629258466


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce58cc723cd8918dd52cf14a89808b0999d128bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1446",
       "triggerID" : "ce58cc723cd8918dd52cf14a89808b0999d128bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce58cc723cd8918dd52cf14a89808b0999d128bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1446) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12175: [FLINK-17692] Keep yarn.classpath in target folder to not pollute local builds

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12175:
URL: https://github.com/apache/flink/pull/12175#issuecomment-629258466


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce58cc723cd8918dd52cf14a89808b0999d128bc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ce58cc723cd8918dd52cf14a89808b0999d128bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce58cc723cd8918dd52cf14a89808b0999d128bc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12175: [FLINK-17692] Keep yarn.classpath in target folder to not pollute local builds

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12175:
URL: https://github.com/apache/flink/pull/12175#issuecomment-629258466


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce58cc723cd8918dd52cf14a89808b0999d128bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1446",
       "triggerID" : "ce58cc723cd8918dd52cf14a89808b0999d128bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce58cc723cd8918dd52cf14a89808b0999d128bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1446) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org