You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by dd...@apache.org on 2021/01/10 18:54:15 UTC

[zookeeper] branch branch-3.6 updated: ZOOKEEPER-4055: Dockerfile can't build Zookeeper C client library

This is an automated email from the ASF dual-hosted git repository.

ddiederen pushed a commit to branch branch-3.6
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/branch-3.6 by this push:
     new 4e1c6d5  ZOOKEEPER-4055: Dockerfile can't build Zookeeper C client library
4e1c6d5 is described below

commit 4e1c6d50238dff87fce2bfc00ec3ef25c85d5a44
Author: okumin <gi...@okumin.com>
AuthorDate: Sun Jan 10 18:50:44 2021 +0000

    ZOOKEEPER-4055: Dockerfile can't build Zookeeper C client library
    
    https://issues.apache.org/jira/browse/ZOOKEEPER-4055
    
    This PR would fix the build by installing `pkg-config` and enabling `PKG_CHECK_MODULES`.
    https://github.com/apache/zookeeper/blob/4e82a8be889d91dde46a11b38c8a20e82f3220f2/zookeeper-client/zookeeper-client-c/acinclude.m4#L314-L327
    
    Another approach is to use a maven image with old Debian but it's less reasonable for me.
    
    Author: okumin <gi...@okumin.com>
    
    Reviewers: Enrico Olivelli <eo...@apache.org>, Damien Diederen <dd...@apache.org>
    
    Closes #1575 from okumin/ZOOKEEPER-4055
    
    (cherry picked from commit eeb053767c9e931ae72a2d8c59c0940da3da9679)
    Signed-off-by: Damien Diederen <dd...@apache.org>
---
 dev/docker/Dockerfile | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/dev/docker/Dockerfile b/dev/docker/Dockerfile
index cead98a..e5c3d45 100644
--- a/dev/docker/Dockerfile
+++ b/dev/docker/Dockerfile
@@ -20,4 +20,12 @@
 FROM maven:3.6.3-jdk-8
 
 RUN apt-get update
-RUN apt-get install -y g++ cmake autoconf libcppunit-dev libtool openssl libssl-dev
+RUN apt-get install -y \
+  g++ \
+  cmake \
+  autoconf \
+  pkg-config \
+  libcppunit-dev \
+  libtool \
+  openssl \
+  libssl-dev
\ No newline at end of file