You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/05/12 17:54:55 UTC
[Impala-CR](cdh5-trunk) IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3035
Change subject: IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
......................................................................
IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
---
M be/src/exec/partitioned-hash-join-node.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/35/3035/1
--
To view, visit http://gerrit.cloudera.org:8080/3035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
......................................................................
Patch Set 1:
This passed an exhaustive test run
--
To view, visit http://gerrit.cloudera.org:8080/3035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3035
to look at the new patch set (#2).
Change subject: IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
......................................................................
IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
---
M be/src/exec/partitioned-hash-join-node.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/35/3035/2
--
To view, visit http://gerrit.cloudera.org:8080/3035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
......................................................................
Patch Set 2: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/3035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
......................................................................
IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
Reviewed-on: http://gerrit.cloudera.org:8080/3035
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/partitioned-hash-join-node.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Internal Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/3035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3527: use codegen'd ProcessProbeBatch() when spilling.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92ebfb01e370d0a842270771c9e5f1a4610dc16a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No