You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Richard Wallace (JIRA)" <ji...@apache.org> on 2008/08/20 08:43:26 UTC
[jira] Created: (WW-2775) Make the decision on whether or not a
Class can be instantiated overridable by subclasses
Make the decision on whether or not a Class can be instantiated overridable by subclasses
-----------------------------------------------------------------------------------------
Key: WW-2775
URL: https://issues.apache.org/struts/browse/WW-2775
Project: Struts 2
Issue Type: Improvement
Components: Plugin - Convention
Reporter: Richard Wallace
Priority: Minor
Attachments: instatiation-check.diff
In the PackageBasedActionConfigBuilder a check is done to see if a found Action class is abstract, an interface, an enum or an annotation. I would like to see this check moved to a protected method that can be overridden as there are some cases where it might be quite alright to have an interface be used for the action. And as long as the ObjectFactory used is able to instantiate an Action for it, that should really be all that matters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2775) Make the decision on whether or not a
Class can be instantiated overridable by subclasses
Posted by "Richard Wallace (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Wallace updated WW-2775:
--------------------------------
Attachment: instatiation-check.diff
> Make the decision on whether or not a Class can be instantiated overridable by subclasses
> -----------------------------------------------------------------------------------------
>
> Key: WW-2775
> URL: https://issues.apache.org/struts/browse/WW-2775
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Reporter: Richard Wallace
> Priority: Minor
> Attachments: instatiation-check.diff
>
>
> In the PackageBasedActionConfigBuilder a check is done to see if a found Action class is abstract, an interface, an enum or an annotation. I would like to see this check moved to a protected method that can be overridden as there are some cases where it might be quite alright to have an interface be used for the action. And as long as the ObjectFactory used is able to instantiate an Action for it, that should really be all that matters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2775) Make the decision on whether or not a
Class can be instantiated overridable by subclasses
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes updated WW-2775:
-----------------------------
Fix Version/s: Future
> Make the decision on whether or not a Class can be instantiated overridable by subclasses
> -----------------------------------------------------------------------------------------
>
> Key: WW-2775
> URL: https://issues.apache.org/struts/browse/WW-2775
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Reporter: Richard Wallace
> Priority: Minor
> Fix For: Future
>
> Attachments: instatiation-check.diff
>
>
> In the PackageBasedActionConfigBuilder a check is done to see if a found Action class is abstract, an interface, an enum or an annotation. I would like to see this check moved to a protected method that can be overridden as there are some cases where it might be quite alright to have an interface be used for the action. And as long as the ObjectFactory used is able to instantiate an Action for it, that should really be all that matters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2775) Make the decision on whether or not a
Class can be instantiated overridable by subclasses
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso resolved WW-2775.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: Future)
2.1.7
fair enough. patch applied, thanks!
> Make the decision on whether or not a Class can be instantiated overridable by subclasses
> -----------------------------------------------------------------------------------------
>
> Key: WW-2775
> URL: https://issues.apache.org/struts/browse/WW-2775
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Reporter: Richard Wallace
> Priority: Minor
> Fix For: 2.1.7
>
> Attachments: instatiation-check.diff
>
>
> In the PackageBasedActionConfigBuilder a check is done to see if a found Action class is abstract, an interface, an enum or an annotation. I would like to see this check moved to a protected method that can be overridden as there are some cases where it might be quite alright to have an interface be used for the action. And as long as the ObjectFactory used is able to instantiate an Action for it, that should really be all that matters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.