[GitHub] guacamole-client pull request #349: GUACAMOLE-678: Implement new UriGuacamol...

[necouchman <gi...@git.apache.org>]

GitHub user necouchman opened a pull request:

    https://github.com/apache/guacamole-client/pull/349

    GUACAMOLE-678: Implement new UriGuacamoleProperty

    This PR implements a new property type, the `UriGuacamoleProperty`, which parses a string into a URI.  Several of the extensions were converted to use the new property, and I also added properties to the JDBC modules that allow for configuring the connection with a single URI property rather than the individual components.  Providing this type of property allows for validation of URI/URLs in the configuration file, catching errors when the configuration is loaded.
    
    The other advantage of using URI is that, from what I have read, it takes care of all of the encoding of the various URL parts internal, which avoids the need to explicitly use `URLEncoder`.
    
    For the JDBC modules, I configured it such that, if the URI is specified, the other module parameters are completely ignored.  This could go the other direction where the URI is the base and the others override it, if desired - it would be a pretty easy change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/necouchman/guacamole-client jira/678

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #349
    
----
commit 1366b6e78743c35a8511cd949cffe8f8f296a443
Author: Nick Couchman <vn...@...>
Date:   2018-12-25T03:08:57Z

    GUACAMOLE-678: Implement new UriGuacamoleProperty.

commit adf09f5edebea522c68bfd3aa71ecd5411771d3e
Author: Nick Couchman <vn...@...>
Date:   2018-12-25T20:24:55Z

    GUACAMOLE-678: Use new UriGuacamoleProperty for extension configuration.

----


---