You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/09/08 00:04:13 UTC

[GitHub] spark pull request #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17435#discussion_r137684263
  
    --- Diff: python/pyspark/sql/types.py ---
    @@ -438,6 +438,11 @@ def toInternal(self, obj):
         def fromInternal(self, obj):
             return self.dataType.fromInternal(obj)
     
    +    def typeName(self):
    +        raise TypeError(
    --- End diff --
    
    Could we do like ...
    
    ```python
    raise TypeError(
        "..."
        "...")
    ```
    if it doesn't bother you much?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org