[GitHub] [spark] cloud-fan commented on a diff in pull request #42112: [SPARK-44493][SQL] Support for translating catalyst expressions into partial datasource filters

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42112:
URL: https://github.com/apache/spark/pull/42112#discussion_r1282716758


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala:
##########
@@ -573,8 +573,10 @@ object DataSourceStrategy
    * @return a `Some[Filter]` if the input [[Expression]] is convertible, otherwise a `None`.
    */
   protected[sql] def translateFilter(

Review Comment:
   can we rename it? It's not pure translation anymore, but kind of extracting filters to do pushdown



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org