You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by aa...@apache.org on 2022/07/19 21:12:01 UTC
[superset] branch arash.afghahi/sc-52998/open-explore-in-a-new-tab-from-sql-lab created (now 89f704961c)
This is an automated email from the ASF dual-hosted git repository.
aafghahi pushed a change to branch arash.afghahi/sc-52998/open-explore-in-a-new-tab-from-sql-lab
in repository https://gitbox.apache.org/repos/asf/superset.git
at 89f704961c amended comment for proper opening
This branch includes the following new commits:
new 89f704961c amended comment for proper opening
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: amended comment for proper opening
Posted by aa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aafghahi pushed a commit to branch arash.afghahi/sc-52998/open-explore-in-a-new-tab-from-sql-lab
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 89f704961ceffb0bcb1ac8145be79563f659f531
Author: AAfghahi <ar...@gmail.com>
AuthorDate: Tue Jul 19 17:09:35 2022 -0400
amended comment for proper opening
---
superset-frontend/src/SqlLab/components/ResultSet/index.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset-frontend/src/SqlLab/components/ResultSet/index.tsx b/superset-frontend/src/SqlLab/components/ResultSet/index.tsx
index 124d2546a6..86da91067b 100644
--- a/superset-frontend/src/SqlLab/components/ResultSet/index.tsx
+++ b/superset-frontend/src/SqlLab/components/ResultSet/index.tsx
@@ -256,7 +256,7 @@ export default class ResultSet extends React.PureComponent<
// const qid = this.props?.query?.results?.query_id;
// if (qid) {
// // This will open explore using the query as datasource
- // window.location.href = `/explore/?dataset_type=query&dataset_id=${qid}`;
+ // window.open(`/explore/?dataset_type=query&dataset_id=${qid}`, '_blank', 'noreferrer');
// } else {
// this.setState({ showSaveDatasetModal: true });
// }