You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/16 03:56:31 UTC

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4362: Match template tags with host tag for vm deployment

nvazquez commented on a change in pull request #4362:
URL: https://github.com/apache/cloudstack/pull/4362#discussion_r709732271



##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -3672,6 +3676,10 @@ else if (!template.isPublicTemplate() && caller.getType() != Account.ACCOUNT_TYP
             sc.addAnd("dataCenterId", SearchCriteria.Op.SC, zoneSc);
         }
 
+        if (templateTag != null && !templateTag.equalsIgnoreCase("")) {

Review comment:
       @DaanHoogland can you explain why? As far as I see it is being passed as a parameter to `templateChecks()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org