You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/20 16:22:42 UTC
[GitHub] [dubbo] AlbumenJ commented on a change in pull request #8840: Add test case for ZookeeperMetadataReportTest
AlbumenJ commented on a change in pull request #8840:
URL: https://github.com/apache/dubbo/pull/8840#discussion_r712323509
##########
File path: dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/MetadataReport.java
##########
@@ -45,7 +45,7 @@
default void publishAppMetadata(SubscriberMetadataIdentifier identifier, MetadataInfo metadataInfo) {
}
- default MetadataInfo getAppMetadata(SubscriberMetadataIdentifier identifier, Map<String, String> instanceMetadata) {
+ default MetadataInfo getAppMetadata(SubscriberMetadataIdentifier identifier) {
Review comment:
Please do not change this method signature. `instanceMetadata` contains some instance releated properties which will take effect when getting metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org