You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Andrew Schwartzmeyer (JIRA)" <ji...@apache.org> on 2018/01/30 19:31:00 UTC

[jira] [Commented] (MESOS-7740) Powershell doesn't catch CRC errors when unzipping a file (fetcher)

    [ https://issues.apache.org/jira/browse/MESOS-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345656#comment-16345656 ] 

Andrew Schwartzmeyer commented on MESOS-7740:
---------------------------------------------

Let's use http://libarchive.org/

Reason: Microsoft is shipping it with the new bundled tar https://blogs.technet.microsoft.com/virtualization/2017/12/19/tar-and-curl-come-to-windows/

> Powershell doesn't catch CRC errors when unzipping a file (fetcher)
> -------------------------------------------------------------------
>
>                 Key: MESOS-7740
>                 URL: https://issues.apache.org/jira/browse/MESOS-7740
>             Project: Mesos
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Jeff Coffler
>            Priority: Minor
>              Labels: windows
>
> On Windows, Powershell is used to decompress zip files within the fetcher.
> In fetcher_tests.cpp, test FetcherTest.Unzip_ExtractInvalidFile, specifically tests for a .zip file with a bad CRC.
> On Linux, this is properly decoded, but considered an error since the 'unzip' utility returns 2.
> On Windows, this is properly decoded and a success code is returned.
> When we move to programmatically decoding container files (tar, gzip, zip, etc), then this issue should be resolved. The test is marked with TODO(jeffaco) for these changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)