You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/17 00:56:34 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request, #18961: [improve][doc] Update PR template and PIP for metrics changes
codelipenghui opened a new pull request, #18961:
URL: https://github.com/apache/pulsar/pull/18961
### Motivation
Update PR template and PIP for metrics changes according to the [discussion](https://lists.apache.org/thread/bmwtk6zcyt4ft4t95jmz1bnsxbysjw8m) under the mailing list
### Modifications
- Add PIP link option to PR template
- Add metrics change to the checklist of the PR template
- Update PIP.md for requiring PIP for metrics changes
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #18961: [improve][doc] Update PR template and PIP for metrics changes
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #18961:
URL: https://github.com/apache/pulsar/pull/18961#discussion_r1051293235
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -60,8 +66,11 @@ This change added tests and can be verified as follows:
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
+- [ ] The metrics
- [ ] Anything that affects deployment
+<!-- NOTE: A PIP is required if the PR will change any parts of the above. See https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->
Review Comment:
This statement is not true: change dependency doesn't always require a PIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #18961: [improve][doc] Update PR template and PIP for metrics changes
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #18961:
URL: https://github.com/apache/pulsar/pull/18961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18961: [improve][doc] Update PR template and PIP for metrics changes
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on code in PR #18961:
URL: https://github.com/apache/pulsar/pull/18961#discussion_r1051395544
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -60,8 +66,11 @@ This change added tests and can be verified as follows:
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
+- [ ] The metrics
- [ ] Anything that affects deployment
+<!-- NOTE: A PIP is required if the PR will change any parts of the above. See https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->
Review Comment:
if fix schema bugs, don't need the PIP, I think the schema option can be removed from here. PRs related to the schema, if you need PIP it's already included in `The default values of configurations` `The public API` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org