You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Andrew Stitcher <as...@apache.org> on 2011/02/17 21:17:18 UTC
Review Request: JCA resource adapter for Qpid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/
-----------------------------------------------------------
Review request for qpid.
Summary
-------
This is the first review candidate for a qpid JCA resource adapter.
So far no build infrastructure is included.
I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
Any and all comments welcome.
This addresses bug QPID-3044.
https://issues.apache.org/jira/browse/QPID-3044
Diffs
-----
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
Diff: https://reviews.apache.org/r/432/diff
Testing
-------
Thanks,
Andrew
Re: Review Request: JCA resource adapter for Qpid
Posted by ke...@gmail.com.
> On 2011-02-18 15:00:31, rajith attapattu wrote:
> > trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java, line 380
> > <https://reviews.apache.org/r/432/diff/1/?file=12446#file12446line380>
> >
> > I am wondering why the destination retrived via the look up method needs to be casted to one AMQTopic or AMQQueue ?
> >
> > For example if you use
> > destination.mydest=<address-string>
> > in the jndi properties file then it will throw up a class cast exception as the object returned will be of type AMQAnyDestination.
>
> kevinconner wrote:
> The jndi properties are not used to populate JNDI, there is a bean in the app server integration responsible for doing this. I do agree that it should be relaxed, however, as other server integrations may inject AMQAnyDestination.
I'll also change the test for Topic so that it is !(destination instanceof Queue), so AMQAnyDestination will always default to Queue unless the type is configured explicitly.
- kevinconner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review237
-----------------------------------------------------------
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by ke...@gmail.com.
> On 2011-02-18 15:00:31, rajith attapattu wrote:
> > trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java, line 380
> > <https://reviews.apache.org/r/432/diff/1/?file=12446#file12446line380>
> >
> > I am wondering why the destination retrived via the look up method needs to be casted to one AMQTopic or AMQQueue ?
> >
> > For example if you use
> > destination.mydest=<address-string>
> > in the jndi properties file then it will throw up a class cast exception as the object returned will be of type AMQAnyDestination.
The jndi properties are not used to populate JNDI, there is a bean in the app server integration responsible for doing this. I do agree that it should be relaxed, however, as other server integrations may inject AMQAnyDestination.
> On 2011-02-18 15:00:31, rajith attapattu wrote:
> > trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java, line 251
> > <https://reviews.apache.org/r/432/diff/1/?file=12447#file12447line251>
> >
> > Does client ack and transacted ack modes not allowed in this case ?
No, they are not allowed as per the JCA/EJB spec.
- kevinconner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review237
-----------------------------------------------------------
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by rajith attapattu <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review237
-----------------------------------------------------------
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java
<https://reviews.apache.org/r/432/#comment487>
I am wondering why the destination retrived via the look up method needs to be casted to one AMQTopic or AMQQueue ?
For example if you use
destination.mydest=<address-string>
in the jndi properties file then it will throw up a class cast exception as the object returned will be of type AMQAnyDestination.
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java
<https://reviews.apache.org/r/432/#comment486>
Does client ack and transacted ack modes not allowed in this case ?
- rajith
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review254
-----------------------------------------------------------
Note that this review has now moved to https://reviews.apache.org/r/441/
- Andrew
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by ke...@gmail.com.
> On 2011-02-18 15:28:45, rajith attapattu wrote:
> > I am wondering what is the reason behind wrapping most of the JMS implementation classes like the various message impls (and the session classes).
> > It seems that this is done to validate if the session is still associated with a valid managed connection ?
> >
> > Perhaps there is a way to minimize the extra classes here by making a few modifications to the AMQSession class and the AbstracJMSMessage classes.
> > Here is a rough idea.
> > We could have the QpidRSession extend the AMQSession class (instead of what it's doing right now) and override the checkNotClosed method to do the necessary checking.
> > Most of the message creation (and other methods) use the "checkNotClosed" method already. We can add it to any methods that don't.
> > This way we can get rid of all the extra wrapper classes.
> >
> > I may have overlooked something, if so please shout. However I think the above is doable.
The wrapper classes provide isolation between different contexts, the association between the QpidRAManagedConnection and QpidRASession changes, and they are discarded regularly. The underlying sessions are retained.
- kevinconner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review239
-----------------------------------------------------------
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by rajith attapattu <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review239
-----------------------------------------------------------
I am wondering what is the reason behind wrapping most of the JMS implementation classes like the various message impls (and the session classes).
It seems that this is done to validate if the session is still associated with a valid managed connection ?
Perhaps there is a way to minimize the extra classes here by making a few modifications to the AMQSession class and the AbstracJMSMessage classes.
Here is a rough idea.
We could have the QpidRSession extend the AMQSession class (instead of what it's doing right now) and override the checkNotClosed method to do the necessary checking.
Most of the message creation (and other methods) use the "checkNotClosed" method already. We can add it to any methods that don't.
This way we can get rid of all the extra wrapper classes.
I may have overlooked something, if so please shout. However I think the above is doable.
- rajith
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by rajith attapattu <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review238
-----------------------------------------------------------
- rajith
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by ke...@gmail.com.
> On 2011-02-18 15:29:28, rajith attapattu wrote:
> > trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java, line 601
> > <https://reviews.apache.org/r/432/diff/1/?file=12424#file12424line601>
> >
> > Does each managed connection have only one session associated with it?
One session and one XASession. The AMQRaSession instances map on to these.
- kevinconner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review240
-----------------------------------------------------------
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by ke...@gmail.com.
> On 2011-02-18 15:29:28, rajith attapattu wrote:
> > trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java, line 601
> > <https://reviews.apache.org/r/432/diff/1/?file=12424#file12424line601>
> >
> > Does each managed connection have only one session associated with it?
>
> kevinconner wrote:
> One session and one XASession. The AMQRaSession instances map on to these.
Sorry, that should be QpidRaSession :)
- kevinconner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review240
-----------------------------------------------------------
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by rajith attapattu <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review240
-----------------------------------------------------------
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java
<https://reviews.apache.org/r/432/#comment488>
Does each managed connection have only one session associated with it?
- rajith
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by ke...@gmail.com.
> On 2011-02-18 06:47:30, Gordon Sim wrote:
> > trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java, line 40
> > <https://reviews.apache.org/r/432/diff/1/?file=12412#file12412line40>
> >
> > This class has been altered, renamed & repackaged since the revision/time recorded in the comments.
> >
> > At the very least we should append some statement to explain that. I would prefer actually removing the author/revisions since their inclusion is not really common practice in Qpid and they will only get stale.
I have no objections to that
> On 2011-02-18 06:47:30, Gordon Sim wrote:
> > trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java, line 37
> > <https://reviews.apache.org/r/432/diff/1/?file=12414#file12414line37>
> >
> > What is the purpose of this class? Since the message it is wrapping is already a JMS BytesMessage, what does the wrapper actually add?
The acknowledge on the base class forces a check to make sure it is still associated with a managed connection before delegating to the underlying message
> On 2011-02-18 06:47:30, Gordon Sim wrote:
> > trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java, line 53
> > <https://reviews.apache.org/r/432/diff/1/?file=12433#file12433line53>
> >
> > What is the envisaged mechanism for deployment in some other App Server - would that require source code changes to the RA itself? Or can it be done through properties? If the latter is there any reason to have one as the default rather than making it required configuration?
There should have been access through the resource adapter, my bad. I'll add those methods and remove the default config so that it is all done through the ra.xml
- kevinconner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review229
-----------------------------------------------------------
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
Re: Review Request: JCA resource adapter for Qpid
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/432/#review229
-----------------------------------------------------------
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java
<https://reviews.apache.org/r/432/#comment477>
This class has been altered, renamed & repackaged since the revision/time recorded in the comments.
At the very least we should append some statement to explain that. I would prefer actually removing the author/revisions since their inclusion is not really common practice in Qpid and they will only get stale.
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java
<https://reviews.apache.org/r/432/#comment478>
What is the purpose of this class? Since the message it is wrapping is already a JMS BytesMessage, what does the wrapper actually add?
trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java
<https://reviews.apache.org/r/432/#comment480>
What is the envisaged mechanism for deployment in some other App Server - would that require source code changes to the RA itself? Or can it be done through properties? If the latter is there any reason to have one as the default rather than making it required configuration?
- Gordon
On 2011-02-17 12:17:18, Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/432/
> -----------------------------------------------------------
>
> (Updated 2011-02-17 12:17:18)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This is the first review candidate for a qpid JCA resource adapter.
>
> So far no build infrastructure is included.
>
> I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm thinking perhaps java/ra would be more usual).
>
> Any and all comments welcome.
>
>
> This addresses bug QPID-3044.
> https://issues.apache.org/jira/browse/QPID-3044
>
>
> Diffs
> -----
>
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION
> trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION
> trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
> trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
> trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
>
> Diff: https://reviews.apache.org/r/432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>