You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:52 UTC

[Impala-CR] IMPALA-3957: Test failure in S3 build: TestLoadData.test load 

Hello Internal Jenkins, Sailesh Mukil,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4221

to review the following change.

Change subject: IMPALA-3957: Test failure in S3 build: TestLoadData.test_load
......................................................................

IMPALA-3957: Test failure in S3 build: TestLoadData.test_load

The test_load() test failed with an error which said that the number of
of files in the destination was wrong. This could probably be because
the filesystem_client.copy() (for S3) in the setup_method() silently
failed without copying one of the files as a one off error.

I'm not sure why S3 failed to do the copy, but this patch adds an
assert after the copy to make sure that if it the s3_client.copy()
fails to do the copy, it will assert instead of continuing with the
rest of the tests.

Change-Id: I966a469e94099d3d971e470ae6e992386070c5e9
Reviewed-on: http://gerrit.cloudera.org:8080/3881
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit ac4f22b1b0a68600884358d373fffbcd817f22b8)
---
M tests/util/s3_util.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/21/4221/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I966a469e94099d3d971e470ae6e992386070c5e9
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-CR] IMPALA-3957: Test failure in S3 build: TestLoadData.test load

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.

Change subject: IMPALA-3957: Test failure in S3 build: TestLoadData.test_load
......................................................................


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/4221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I966a469e94099d3d971e470ae6e992386070c5e9
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>