You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/01/20 16:47:00 UTC
[jira] [Work logged] (AVRO-3314) ArgumentOutOfRangeException thrown in AvroDecimal IConvertable.ToType
[ https://issues.apache.org/jira/browse/AVRO-3314?focusedWorklogId=712188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712188 ]
ASF GitHub Bot logged work on AVRO-3314:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 16:46
Start Date: 20/Jan/22 16:46
Worklog Time Spent: 10m
Work Description: KyleSchoonover opened a new pull request #1467:
URL: https://github.com/apache/avro/pull/1467
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [[Avro Jira](https://issues.apache.org/jira/browse/AVRO/](https://issues.apache.org/jira/browse/AVRO-3314)) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/AVRO-3314
### Tests
- [ ] My PR does not need testing for this extremely good reason: This is a throw exception change. Not a logic change.
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- Documentation updated in code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 712188)
Remaining Estimate: 0h
Time Spent: 10m
> ArgumentOutOfRangeException thrown in AvroDecimal IConvertable.ToType
> ---------------------------------------------------------------------
>
> Key: AVRO-3314
> URL: https://issues.apache.org/jira/browse/AVRO-3314
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> IConvertable.ToType is throwing an ArgumentOutOfRangeException, which is not the correct exception to throw since the arguments being passed are not what can cause the exception. This should be changed to an ArithmeticException, specifically an OverflowException.
> For reference: [ArithmeticException Class (System) | Microsoft Docs|https://docs.microsoft.com/en-us/dotnet/api/system.arithmeticexception?view=net-6.0]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)