You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Thilo Goetz (JIRA)" <ui...@incubator.apache.org> on 2008/01/31 07:17:38 UTC

[jira] Commented: (UIMA-735) ResultSpecification_impl missing equals and hashCode for inner class - causing intermittant test case failure

    [ https://issues.apache.org/jira/browse/UIMA-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564316#action_12564316 ] 

Thilo Goetz commented on UIMA-735:
----------------------------------

Any particular reason you didn't close this issue?


> ResultSpecification_impl missing equals and hashCode for inner class - causing intermittant test case failure
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: UIMA-735
>                 URL: https://issues.apache.org/jira/browse/UIMA-735
>             Project: UIMA
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Marshall Schor
>            Assignee: Marshall Schor
>            Priority: Minor
>             Fix For: 2.3
>
>
> The ResultSpec impl has an inner class, ToF_Languages.  When comparing 2 result specificaitons for equal in test cases, these are compared.  But they are missing an equals (and hashCode) methods.  So the test case fails to say they're equal unless they're identical.  But cloning happens a lot in the way Result specs are used, and in this test, they may be equal (I think) but not ==.
> Solution: Add proper equals and hashCode to this inner class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Commented: (UIMA-735) ResultSpecification_impl missing equals and hashCode for inner class - causing intermittant test case failure

Posted by Marshall Schor <ms...@schor.com>.
Thilo Goetz wrote:
> Marshall Schor wrote:
>> Thilo Goetz (JIRA) wrote:
>>>     [ 
>>> https://issues.apache.org/jira/browse/UIMA-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564316#action_12564316 
>>> ]
>>> Thilo Goetz commented on UIMA-735:
>>> ----------------------------------
>>>
>>> Any particular reason you didn't close this issue?
>>>   
>> Because the condition which led me to suspect this is quite 
>> intermittant, I wanted to run tests for a few days to be sure that 
>> was the cause.
>>
>> -Marshall
>
> It would be good then if you could put that in a comment
> in Jira.  It's confusing to see the status change to
> "resolved" without any indication what is needed to close
> the issue.
OK - you make a good point :-).  -Marshall
>
> --Thilo
>
>
>

Re: [jira] Commented: (UIMA-735) ResultSpecification_impl missing equals and hashCode for inner class - causing intermittant test case failure

Posted by Thilo Goetz <tw...@gmx.de>.
Marshall Schor wrote:
> Thilo Goetz (JIRA) wrote:
>>     [ 
>> https://issues.apache.org/jira/browse/UIMA-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564316#action_12564316 
>> ]
>> Thilo Goetz commented on UIMA-735:
>> ----------------------------------
>>
>> Any particular reason you didn't close this issue?
>>   
> Because the condition which led me to suspect this is quite 
> intermittant, I wanted to run tests for a few days to be sure that was 
> the cause.
> 
> -Marshall

It would be good then if you could put that in a comment
in Jira.  It's confusing to see the status change to
"resolved" without any indication what is needed to close
the issue.

--Thilo

Re: [jira] Commented: (UIMA-735) ResultSpecification_impl missing equals and hashCode for inner class - causing intermittant test case failure

Posted by Marshall Schor <ms...@schor.com>.
Thilo Goetz (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/UIMA-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564316#action_12564316 ] 
>
> Thilo Goetz commented on UIMA-735:
> ----------------------------------
>
> Any particular reason you didn't close this issue?
>   
Because the condition which led me to suspect this is quite 
intermittant, I wanted to run tests for a few days to be sure that was 
the cause.

-Marshall
>
>   
>> ResultSpecification_impl missing equals and hashCode for inner class - causing intermittant test case failure
>> -------------------------------------------------------------------------------------------------------------
>>
>>                 Key: UIMA-735
>>                 URL: https://issues.apache.org/jira/browse/UIMA-735
>>             Project: UIMA
>>          Issue Type: Bug
>>    Affects Versions: 2.2.1
>>            Reporter: Marshall Schor
>>            Assignee: Marshall Schor
>>            Priority: Minor
>>             Fix For: 2.3
>>
>>
>> The ResultSpec impl has an inner class, ToF_Languages.  When comparing 2 result specificaitons for equal in test cases, these are compared.  But they are missing an equals (and hashCode) methods.  So the test case fails to say they're equal unless they're identical.  But cloning happens a lot in the way Result specs are used, and in this test, they may be equal (I think) but not ==.
>> Solution: Add proper equals and hashCode to this inner class.
>>     
>
>