You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/25 10:29:13 UTC

[GitHub] [apisix-ingress-controller] neverCase opened a new pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

neverCase opened a new pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845


   <!-- Please answer these questions before submitting a pull request -->
   
   ### Type of change:
   
   <!-- Please delete options that are not relevant. -->
   
   - [X] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the requirements:
   1. Use Draft if the PR is not ready to be reviewed
   2. Test is required for the feat/fix PR, unless you have a good reason
   3. Doc is required for the feat PR
   4. Use a new commit to resolve review instead of `push -f`
   5. Use "request review" to notify the reviewer once you have resolved the review
   -->
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r806564381



##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -530,17 +530,8 @@ func (t *translator) translateHTTPRouteV2beta3(ctx *TranslateContext, ar *config
 		route.EnableWebsocket = part.Websocket
 		route.Plugins = pluginMap
 		route.Timeout = timeout
-		pluginConfig := apisixv1.NewDefaultPluginConfig()
-		if len(pluginMap) > 0 {
-			pluginConfigName := apisixv1.ComposePluginConfigName(ar.Namespace, backend.ServiceName)
-			route.PluginConfigId = id.GenID(pluginConfigName)
-			pluginConfig.ID = route.PluginConfigId
-			pluginConfig.Name = pluginConfigName
-			pluginConfig.Plugins = pluginMap
-		} else {
-			if part.PluginConfigName != "" {
-				route.PluginConfigId = part.PluginConfigName
-			}
+		if part.PluginConfigName != "" {
+			route.PluginConfigId = part.PluginConfigName

Review comment:
       We don't use the plugin config name as the id, see https://github.com/apache/apisix-ingress-controller/blob/master/pkg/kube/translation/apisix_pluginconfig.go#L51 for details.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1056900839


   CI is green. Wait for @tokers  approval 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase removed a comment on pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase removed a comment on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1049535683


   @tao12345666333 
   The case `check the ingress lb status is updated` ran failed.
   Please re-run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on a change in pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r812713561



##########
File path: pkg/ingress/apisix_route.go
##########
@@ -237,27 +234,20 @@ func (c *apisixRouteController) sync(ctx context.Context, ev *types.Event) error
 	return c.controller.syncManifests(ctx, added, updated, deleted)
 }
 
-func (c *apisixRouteController) replacePluginNameWithIdIfNotEmptyV2beta3(ctx context.Context, in *v2beta3.ApisixRoute) (*v2beta3.ApisixRoute, error) {
-	clusterName := c.controller.cfg.APISIX.DefaultClusterName
-	news := make([]v2beta3.ApisixRouteHTTP, 0)
+func (c *apisixRouteController) checkPluginNameIfNotEmptyV2beta3(ctx context.Context, in *v2beta3.ApisixRoute) error {
 	for _, v := range in.Spec.HTTP {
-		pluginConfigId := ""
 		if v.PluginConfigName != "" {
-			pc, err := c.controller.apisix.Cluster(clusterName).PluginConfig().Get(ctx, apisixv1.ComposePluginConfigName(in.Namespace, v.PluginConfigName))
+			_, err := c.controller.apisix.Cluster(c.controller.cfg.APISIX.DefaultClusterName).PluginConfig().Get(ctx, apisixv1.ComposePluginConfigName(in.Namespace, v.PluginConfigName))
 			if err != nil {
-				log.Errorw("replacePluginNameWithIdIfNotEmptyV2beta3 error:  plugin_config not found",

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r812526858



##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -977,13 +964,6 @@ func (t *translator) translateHTTPRouteV2beta3NotStrictly(ctx *TranslateContext,
 		route := apisixv1.NewDefaultRoute()
 		route.Name = apisixv1.ComposeRouteName(ar.Namespace, ar.Name, part.Name)
 		route.ID = id.GenID(route.Name)
-		pluginConfig := apisixv1.NewDefaultPluginConfig()

Review comment:
       Why we don't handle the `PluginConfigName` in this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1022076000


   ci error below:
   ```sh
   • Failure [70.707 seconds]
   ApisixRoute Testing
   /home/runner/work/apisix-ingress-controller/apisix-ingress-controller/test/e2e/ingress/resourcepushing.go:28
     service is referenced by two ApisixRoutes [It]
     /home/runner/work/apisix-ingress-controller/apisix-ingress-controller/test/e2e/ingress/resourcepushing.go:502
   
     
     	Error Trace:	resourcepushing.go:607
     	            				runner.go:113
     	            				runner.go:64
     	            				it_node.go:26
     	            				spec.go:215
     	            				spec.go:138
     	            				spec_runner.go:200
     	            				spec_runner.go:170
     	            				spec_runner.go:66
     	            				suite.go:79
     	            				ginkgo_dsl.go:238
     	            				ginkgo_dsl.go:213
     	            				e2e_test.go:26
     	Error:      	"[%!s(*v1.Upstream=&{{45e6c8e6 ingress-apisix-e2e-tests-default-428202328_httpbin-service-e2e-test_80 Created by apisix-ingress-controller, DO NOT modify it manually map[managed-by:apisix-ingress-controller]} roundrobin vars  <nil> [{10.244.2.32 80 100}] http <nil> <nil> <nil>})]" should have 0 item(s), but has 1
     	Test:       	ApisixRoute Testing service is referenced by two ApisixRoutes
   ```
   maybe it need to re-run once again. @tao12345666333 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021838522


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#845](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5aada25) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/de522437bd3db3dc3e8d8f33c92f322de67531b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de52243) will **increase** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #845      +/-   ##
   ==========================================
   + Coverage   32.12%   32.16%   +0.04%     
   ==========================================
     Files          70       70              
     Lines        7724     7706      -18     
   ==========================================
   - Hits         2481     2479       -2     
   + Misses       4968     4954      -14     
   + Partials      275      273       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `22.16% <100.00%> (+0.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de52243...5aada25](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021814240


   > Need some test cases to make sure the plugin_config_id is not written now.
   
   ok, I will add more test cases today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1038549994


   https://github.com/apache/apisix-ingress-controller/pull/859 has been merged. Re-run the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1049578748


   @tao12345666333 
   Ingress case `check the ingress lb status is updated` run failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1049535683


   @tao12345666333 
   The case `check the ingress lb status is updated` ran failed.
   Please re-run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1034350042


   Wait for #859 to fix CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r806564381



##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -530,17 +530,8 @@ func (t *translator) translateHTTPRouteV2beta3(ctx *TranslateContext, ar *config
 		route.EnableWebsocket = part.Websocket
 		route.Plugins = pluginMap
 		route.Timeout = timeout
-		pluginConfig := apisixv1.NewDefaultPluginConfig()
-		if len(pluginMap) > 0 {
-			pluginConfigName := apisixv1.ComposePluginConfigName(ar.Namespace, backend.ServiceName)
-			route.PluginConfigId = id.GenID(pluginConfigName)
-			pluginConfig.ID = route.PluginConfigId
-			pluginConfig.Name = pluginConfigName
-			pluginConfig.Plugins = pluginMap
-		} else {
-			if part.PluginConfigName != "" {
-				route.PluginConfigId = part.PluginConfigName
-			}
+		if part.PluginConfigName != "" {
+			route.PluginConfigId = part.PluginConfigName

Review comment:
       We don't use the plugin config name as the id, see https://github.com/apache/apisix-ingress-controller/blob/master/pkg/kube/translation/apisix_pluginconfig.go#L51 for details.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021838522


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#845](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa0443e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/6b0c139ce2fbf56c683d86b8f93c7b4ef854fbc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b0c139) will **increase** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #845      +/-   ##
   ==========================================
   + Coverage   32.07%   32.12%   +0.05%     
   ==========================================
     Files          70       71       +1     
     Lines        7736     7719      -17     
   ==========================================
   - Hits         2481     2480       -1     
   + Misses       4980     4966      -14     
   + Partials      275      273       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `22.16% <100.00%> (+0.33%)` | :arrow_up: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | `100.00% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b0c139...fa0443e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r806974844



##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -530,17 +530,8 @@ func (t *translator) translateHTTPRouteV2beta3(ctx *TranslateContext, ar *config
 		route.EnableWebsocket = part.Websocket
 		route.Plugins = pluginMap
 		route.Timeout = timeout
-		pluginConfig := apisixv1.NewDefaultPluginConfig()
-		if len(pluginMap) > 0 {
-			pluginConfigName := apisixv1.ComposePluginConfigName(ar.Namespace, backend.ServiceName)
-			route.PluginConfigId = id.GenID(pluginConfigName)
-			pluginConfig.ID = route.PluginConfigId
-			pluginConfig.Name = pluginConfigName
-			pluginConfig.Plugins = pluginMap
-		} else {
-			if part.PluginConfigName != "" {
-				route.PluginConfigId = part.PluginConfigName
-			}
+		if part.PluginConfigName != "" {
+			route.PluginConfigId = part.PluginConfigName

Review comment:
       Yes， This is what needs to be refactored.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on a change in pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r808851238



##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -530,17 +530,8 @@ func (t *translator) translateHTTPRouteV2beta3(ctx *TranslateContext, ar *config
 		route.EnableWebsocket = part.Websocket
 		route.Plugins = pluginMap
 		route.Timeout = timeout
-		pluginConfig := apisixv1.NewDefaultPluginConfig()
-		if len(pluginMap) > 0 {
-			pluginConfigName := apisixv1.ComposePluginConfigName(ar.Namespace, backend.ServiceName)
-			route.PluginConfigId = id.GenID(pluginConfigName)
-			pluginConfig.ID = route.PluginConfigId
-			pluginConfig.Name = pluginConfigName
-			pluginConfig.Plugins = pluginMap
-		} else {
-			if part.PluginConfigName != "" {
-				route.PluginConfigId = part.PluginConfigName
-			}
+		if part.PluginConfigName != "" {
+			route.PluginConfigId = part.PluginConfigName

Review comment:
       ok, I will refactor it right now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021838522


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#845](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d723a7) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/32a096c24dd330e537fd5fed7fcccb63fd8dd813?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32a096c) will **increase** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #845      +/-   ##
   ==========================================
   + Coverage   32.07%   32.11%   +0.04%     
   ==========================================
     Files          71       70       -1     
     Lines        7739     7720      -19     
   ==========================================
   - Hits         2482     2479       -3     
   + Misses       4982     4968      -14     
   + Partials      275      273       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `22.16% <100.00%> (+0.33%)` | :arrow_up: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32a096c...8d723a7](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase edited a comment on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase edited a comment on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1043866935


   Actually, I found I had covert the plugin config name to plugin id in the apisixRouteController.
   https://github.com/apache/apisix-ingress-controller/blob/master/pkg/ingress/apisix_route.go#L240
   @tokers 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1043866935


   Actually, I found I had covert the plugin config name to plugin id in the apisixRouteController.
   https://github.com/apache/apisix-ingress-controller/blob/master/pkg/ingress/apisix_route.go#L240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r806974844



##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -530,17 +530,8 @@ func (t *translator) translateHTTPRouteV2beta3(ctx *TranslateContext, ar *config
 		route.EnableWebsocket = part.Websocket
 		route.Plugins = pluginMap
 		route.Timeout = timeout
-		pluginConfig := apisixv1.NewDefaultPluginConfig()
-		if len(pluginMap) > 0 {
-			pluginConfigName := apisixv1.ComposePluginConfigName(ar.Namespace, backend.ServiceName)
-			route.PluginConfigId = id.GenID(pluginConfigName)
-			pluginConfig.ID = route.PluginConfigId
-			pluginConfig.Name = pluginConfigName
-			pluginConfig.Plugins = pluginMap
-		} else {
-			if part.PluginConfigName != "" {
-				route.PluginConfigId = part.PluginConfigName
-			}
+		if part.PluginConfigName != "" {
+			route.PluginConfigId = part.PluginConfigName

Review comment:
       Yes， This is what needs to be refactored.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1039709344


   ping @tokers @gxthrj  for review, thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r812694516



##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -977,13 +964,6 @@ func (t *translator) translateHTTPRouteV2beta3NotStrictly(ctx *TranslateContext,
 		route := apisixv1.NewDefaultRoute()
 		route.Name = apisixv1.ComposeRouteName(ar.Namespace, ar.Name, part.Name)
 		route.ID = id.GenID(route.Name)
-		pluginConfig := apisixv1.NewDefaultPluginConfig()

Review comment:
       Well, I mean `translateHTTPRouteV2beta3NotStrictly` is basically same to `translateHTTPRouteV2beta3`, so here you should also set the plugin config id.

##########
File path: pkg/ingress/apisix_route.go
##########
@@ -237,27 +234,20 @@ func (c *apisixRouteController) sync(ctx context.Context, ev *types.Event) error
 	return c.controller.syncManifests(ctx, added, updated, deleted)
 }
 
-func (c *apisixRouteController) replacePluginNameWithIdIfNotEmptyV2beta3(ctx context.Context, in *v2beta3.ApisixRoute) (*v2beta3.ApisixRoute, error) {
-	clusterName := c.controller.cfg.APISIX.DefaultClusterName
-	news := make([]v2beta3.ApisixRouteHTTP, 0)
+func (c *apisixRouteController) checkPluginNameIfNotEmptyV2beta3(ctx context.Context, in *v2beta3.ApisixRoute) error {
 	for _, v := range in.Spec.HTTP {
-		pluginConfigId := ""
 		if v.PluginConfigName != "" {
-			pc, err := c.controller.apisix.Cluster(clusterName).PluginConfig().Get(ctx, apisixv1.ComposePluginConfigName(in.Namespace, v.PluginConfigName))
+			_, err := c.controller.apisix.Cluster(c.controller.cfg.APISIX.DefaultClusterName).PluginConfig().Get(ctx, apisixv1.ComposePluginConfigName(in.Namespace, v.PluginConfigName))
 			if err != nil {
-				log.Errorw("replacePluginNameWithIdIfNotEmptyV2beta3 error:  plugin_config not found",

Review comment:
       Should distinguish the error type, not all errors are "not found".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1049579447


   let me re-run it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021838522


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#845](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4547a1a) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/d30bef56d5502724901c7eae42b319ad1b92c76c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d30bef5) will **increase** coverage by `0.07%`.
   > The diff coverage is `17.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #845      +/-   ##
   ==========================================
   + Coverage   32.01%   32.09%   +0.07%     
   ==========================================
     Files          70       70              
     Lines        7749     7730      -19     
   ==========================================
     Hits         2481     2481              
   + Misses       4993     4976      -17     
   + Partials      275      273       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `22.43% <100.00%> (+0.60%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d30bef5...4547a1a](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1039709344


   ping @tokers @gxthrj  for review, thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021082088


   ci need re-run @tao12345666333 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1043867934


   It's been a long time and I almost forgot what I had done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on a change in pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on a change in pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#discussion_r812572951



##########
File path: pkg/kube/translation/apisix_route.go
##########
@@ -977,13 +964,6 @@ func (t *translator) translateHTTPRouteV2beta3NotStrictly(ctx *TranslateContext,
 		route := apisixv1.NewDefaultRoute()
 		route.Name = apisixv1.ComposeRouteName(ar.Namespace, ar.Name, part.Name)
 		route.ID = id.GenID(route.Name)
-		pluginConfig := apisixv1.NewDefaultPluginConfig()

Review comment:
       That's because when it creates the ApisixRoute and the field `PluginConfigName` has been specified, I want to use apisix.Cluster api to check the plugin was whether exist.
    And at the same time replace it with the plugin id.
   ...
   Since the method to generate the plugin id is fixed.
   I will just remove the replacement and remain checking.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #845: fix: avoid create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021082088


   ci need re-run @tao12345666333 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021878365


   e2e test need to re-run @tao12345666333 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021838522


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#845](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c090ab7) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/de522437bd3db3dc3e8d8f33c92f322de67531b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de52243) will **increase** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #845      +/-   ##
   ==========================================
   + Coverage   32.12%   32.16%   +0.04%     
   ==========================================
     Files          70       70              
     Lines        7724     7706      -18     
   ==========================================
   - Hits         2481     2479       -2     
   + Misses       4968     4954      -14     
   + Partials      275      273       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `22.16% <100.00%> (+0.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de52243...c090ab7](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021838522


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#845](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa0443e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/6b0c139ce2fbf56c683d86b8f93c7b4ef854fbc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b0c139) will **increase** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #845      +/-   ##
   ==========================================
   + Coverage   32.07%   32.11%   +0.04%     
   ==========================================
     Files          70       70              
     Lines        7736     7718      -18     
   ==========================================
   - Hits         2481     2479       -2     
   + Misses       4980     4966      -14     
   + Partials      275      273       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `22.16% <100.00%> (+0.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b0c139...fa0443e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1038549994


   https://github.com/apache/apisix-ingress-controller/pull/859 has been merged. Re-run the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #845:
URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1021838522


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#845](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa0443e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/6b0c139ce2fbf56c683d86b8f93c7b4ef854fbc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b0c139) will **increase** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #845      +/-   ##
   ==========================================
   + Coverage   32.07%   32.11%   +0.04%     
   ==========================================
     Files          70       70              
     Lines        7736     7718      -18     
   ==========================================
   - Hits         2481     2479       -2     
   + Misses       4980     4966      -14     
   + Partials      275      273       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `22.16% <100.00%> (+0.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b0c139...fa0443e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/845?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org