You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Glenn A. Thompson" <gt...@cdr.net> on 2002/12/27 20:01:43 UTC
[PATCH] Bomb blast -> fire cracker 1
Hey,
Once again:
http://www.cdrguys.com/subversion/index.html
Sorry, I've been so slow on this. I've brought the bomb blast version
of my first FS patch up to rev 4196.
I have made some changes to the patch to fix concerns raised by CMike
and Garrett Rooney. Although I may try to change your mind on one
change Mike. I'll bring it up again when I get to the increment which
raises the issue.
In a cell down and to the right I will be posting the incremental patches.
The first is one is there. Basically it just does the function renames
as CMike requested. There will be additional changes to most if not all
of the files modified in this first patch. In some cases the same
modified lines will be replaced as I decided not to do any vtable work
in this patch. It tended to cascade quick, which is how I ended up with
such a large patch to begin with:-)
Both the master and the incremental pass the test suite (local and dav)
on my Suse 7.3 box.
The next increment will be the db_cntxt changes and the moving of all
the DB code from fs.c to a new file bdb-fs.c
I may add the two "inner vtables" code to it but I doubt it.
Assuming I don't decide to add the inner vtables, The next increment
will include the inner vtable work and all that they require.
The next will be the outer (api aka veneer) vtable
Whatever is left will be placed in a final patch.
See the master patch to get more detail on my direction.:w
Remember this whole patch should be a "noop" unless I accidentally broke
something in which case it will be an "oops":-)
I'm heading out of town for two days. So I won't be checking e-mail
very often.
Happy Holidays Folks,
gat
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Bomb blast -> fire cracker 1
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
"Glenn A. Thompson" <gt...@cdr.net> writes:
> In a cell down and to the right I will be posting the incremental patches.
> The first is one is there. Basically it just does the function
> renames as CMike requested. There will be additional changes to most
> if not all of the files modified in this first patch. In some cases
> the same modified lines will be replaced as I decided not to do any
> vtable work in this patch. It tended to cascade quick, which is how I
> ended up with such a large patch to begin with:-)
Glenn, thanks for breaking it down!
I've got some other stuff on my plate during this holiday (checksums,
plus some non-Subversion things), but will try to find time to review
this and maybe apply. Hard work is best thanked with more work :-).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Bomb blast -> fire cracker 1
Posted by cm...@collab.net.
"Glenn A. Thompson" <gt...@cdr.net> writes:
> Hey,
>
> Once again:
> http://www.cdrguys.com/subversion/index.html
>
> Sorry, I've been so slow on this. I've brought the bomb blast version
> of my first FS patch up to rev 4196.
> I have made some changes to the patch to fix concerns raised by CMike
> and Garrett Rooney. Although I may try to change your mind on one
> change Mike. I'll bring it up again when I get to the increment which
> raises the issue.
Hey, Glenn. Looking at your patch now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Bomb blast -> fire cracker 1
Posted by "Glenn A. Thompson" <gt...@cdr.net>.
Karl Fogel wrote:
>cmpilato@collab.net writes:
>
>
>>>Sorry, I've been so slow on this. I've brought the bomb blast version
>>>of my first FS patch up to rev 4196.
>>>
>>>
>>Committed as revision 4208.
>>
>>
>
>I know Glenn's going to thank you, but I want to get my chance as well:
>
You are wrong, I'm going to kiss him smooooooooch!
gat
Re: [PATCH] Bomb blast -> fire cracker 1
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
cmpilato@collab.net writes:
> > Sorry, I've been so slow on this. I've brought the bomb blast version
> > of my first FS patch up to rev 4196.
>
> Committed as revision 4208.
I know Glenn's going to thank you, but I want to get my chance as well:
THANK YOU MIKE! :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Bomb blast -> fire cracker 1
Posted by cm...@collab.net.
"Glenn A. Thompson" <gt...@cdr.net> writes:
> Hey,
>
> Once again:
> http://www.cdrguys.com/subversion/index.html
>
> Sorry, I've been so slow on this. I've brought the bomb blast version
> of my first FS patch up to rev 4196.
Committed as revision 4208.
> The next increment will be the db_cntxt changes and the moving of all
> the DB code from fs.c to a new file bdb-fs.c
> I may add the two "inner vtables" code to it but I doubt it.
I'd doing these changes as three individual ones:
1. Move db code from fs.c to bdb/bdb-fs.c, maintaining the public API
as-is.
2. The db_cntxt changes.
3. The "inner vtables" changes.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org