[GitHub] [accumulo] hkeebler commented on a change in pull request #1155: fix #405 - Utilize newTableConfig in ITs

[GitBox <gi...@apache.org>]

hkeebler commented on a change in pull request #1155: fix #405 - Utilize newTableConfig in ITs
URL: https://github.com/apache/accumulo/pull/1155#discussion_r282600168
 
 

 ##########
 File path: test/src/main/java/org/apache/accumulo/test/functional/SessionDurabilityIT.java
 ##########
 @@ -55,8 +58,8 @@ public void nondurableTableHasDurableWrites() throws Exception {
     try (AccumuloClient c = Accumulo.newClient().from(getClientProperties()).build()) {
       String tableName = getUniqueNames(1)[0];
       // table default has no durability
-      c.tableOperations().create(tableName);
-      c.tableOperations().setProperty(tableName, Property.TABLE_DURABILITY.getKey(), "none");
+      c.tableOperations().create(tableName, new NewTableConfiguration()
+          .setProperties(Collections.singletonMap(Property.TABLE_DURABILITY.getKey(), "none")));
 
 Review comment:
   You mean
   `static final Map<k,v> DURABILITY_NONE = Collections.singletonMap(Property.TABLE_DURABILITY.getKey(), "none");`
   ...etc.
   and then refer to 
   ```
   c.tableOperations().create(tableName, new NewTableConfiguration()
             .setProperties(DURABILITY_NONE);
   ```
   Should I review the others for something similiar where possible?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services